From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25850 invoked by alias); 30 Apr 2010 15:06:03 -0000 Received: (qmail 25841 invoked by uid 22791); 30 Apr 2010 15:06:02 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 15:05:54 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3UF5pb4068365 for ; Fri, 30 Apr 2010 17:05:51 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3UF5ohp017927 for ; Fri, 30 Apr 2010 17:05:50 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3UF5oqj072414 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Fri, 30 Apr 2010 17:05:50 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <000f01cadf9e$a4fd4910$eef7db30$@muller@ics-cnrs.unistra.fr> <002401cae7ea$ba4b48e0$2ee1daa0$@muller@ics-cnrs.unistra.fr> <20100430145338.GA11512@ednor.casa.cgf.cx> In-Reply-To: <20100430145338.GA11512@ednor.casa.cgf.cx> Subject: RE: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type Date: Fri, 30 Apr 2010 15:06:00 -0000 Message-ID: <000601cae876$a1459f80$e3d0de80$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00989.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Christopher Faylor > Envoy=E9=A0: Friday, April 30, 2010 4:54 PM > =C0=A0: gdb-patches@sourceware.org; Pierre Muller > Objet=A0: Re: [PING] [RFC/Windows] Remember last tlb type for re-use in > windows_get_tlb_type >=20 > On Fri, Apr 30, 2010 at 12:24:26AM +0200, Pierre Muller wrote: > >Nobody reacted to this: > >http://sourceware.org/ml/gdb-patches/2010-04/msg00552.html > > > >It helps avoid some unnecessary recomputation. >=20 > Looks ok but is this computation really so onerous that we need to add > the extra code? Each time you dereference $_tlb you recreate the same bunch of internal types leaving the other types in the wild... This looses computation time and memory. Imagine that you use a long script with a breakpoint that has commands associated that print $_tlb.current_seh to check if the current structured exception handler has changed.... Honestly, I don't know if it can become a big problem, but I thought it would be better to avoid it. I first was thinking about removing old values, but I didn't find a clean way to remove the type and all its dependents... Pierre Muller