Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] testsuite/gdb.base/fullname.exp fix
Date: Fri, 19 Jun 2009 22:15:00 -0000	[thread overview]
Message-ID: <000501c9f12b$68c860e0$3a5922a0$@u-strasbg.fr> (raw)


  fullname.exp currently fails compilation
of windows targets because it tries to recompile
the executable, while it is still running under GDB.

  This patch exits GDB before recompilation.

Is this patch OK?


Pierre Muller
Pascal language support maintainer for GDB


PS:   Applying this patch to cygwin reveals a
problem concerning the set_unbuffered_mode object.
  This file is added as an additional object for linking,
but it is added without path information, and this
does not work inside fullname.exp test, as the 
working directory is moved here on purpose
to check GDB's ability to handle different 
relative path names for sources in debug information.

  Does anyone have an idea how to fix this?


2009-06-19  Pierre Muller  <muller@ics.u-strasbg.fr>

	* fullname.exp: Exit gdb before recompile as some operating systems
	lock the executable while it is running.

Index: src/gdb/testsuite/gdb.base/fullname.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/fullname.exp,v
retrieving revision 1.3
diff -u -p -r1.3 fullname.exp
--- src/gdb/testsuite/gdb.base/fullname.exp	3 Jan 2009 05:58:03 -0000
1.3
+++ src/gdb/testsuite/gdb.base/fullname.exp	19 Jun 2009 21:55:01 -0000
@@ -71,12 +71,12 @@ if { [gdb_breakpoint ${objdir}/${subdir}
     fail $msg
 }
 
+gdb_exit
 # Build the test executable using a relative path.
 if  { [gdb_compile "${subdir}/tmp-${srcfile}" "${binfile}" executable
{debug}] != "" } {
     return -1
 }
 
-gdb_exit
 gdb_start
 gdb_load ${binfile}
 
@@ -97,6 +97,7 @@ if { [gdb_breakpoint ${objdir}/${subdir}
     fail $msg
 }
 
+gdb_exit
 # Build the test executable using relative paths not relative to the
directory
 # we'll run GDB from.
 
@@ -108,7 +109,6 @@ if  { [gdb_compile "tmp-${srcfile}" "${t
 }
 cd $save_pwd
 
-gdb_exit
 gdb_start
 gdb_load ${binfile}
 


             reply	other threads:[~2009-06-19 22:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 22:15 Pierre Muller [this message]
2009-06-21  1:27 ` Pedro Alves
2009-06-21 13:48   ` Eli Zaretskii
2009-06-21 16:45     ` Pierre Muller
2009-06-21 23:17       ` Eli Zaretskii
2009-06-25 22:29         ` Pierre Muller
2009-06-27 14:39           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000501c9f12b$68c860e0$3a5922a0$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox