From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99599-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13987 invoked by alias); 15 Mar 2013 16:52:14 -0000
Received: (qmail 13962 invoked by uid 22791); 15 Mar 2013 16:52:10 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Mar 2013 16:52:04 +0000
Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2FGpqK3054785           ; Fri, 15 Mar 2013 17:51:52 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114])           by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2FGppEW016504           ; Fri, 15 Mar 2013 17:51:52 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2FGpo2E006504 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Fri, 15 Mar 2013 17:51:50 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Tom Tromey'" <tromey@redhat.com>, "'Yao Qi'" <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
References: <20130315020212.GA23545@sourceware.org>	<5142E409.5090109@codesourcery.com>	<002901ce2162$414d7530$c3e85f90$@muller@ics-cnrs.unistra.fr>	<51430063.2060007@codesourcery.com>	<5143335C.2010902@codesourcery.com> <878v5o1un6.fsf@fleche.redhat.com>
In-Reply-To: <878v5o1un6.fsf@fleche.redhat.com>
Subject: RE: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt)
Date: Fri, 15 Mar 2013 16:55:00 -0000
Message-ID: <000401ce219d$6322cc10$29686430$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00675.txt.bz2

> Yao>    /* Create DIRNAME.  */
> Yao> -  if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH |
S_IXOTH)
> Yao> -      && errno != EEXIST)
> Yao> +#ifdef USE_WIN32API
> Yao> +  ret = mkdir (dirname);
> Yao> +#else
> Yao> +  ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR);
> Yao> +#endif
> 
> I think S_IRUSR, S_IWUSR,and S_IXUSR are generally ok.
> At least, I see them unprotected in remote-fileio.c.
> So I think a simpler patch here would suffice, and would be cleaner
> besides.

  Tom, this second part is really about the fact that mkdir for
WIN32API doesn't have a second argument, contrary to the usual case.
See for instance Binutils/bucomm.c line 538.


Pierre Muller