From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19908 invoked by alias); 21 Mar 2011 16:27:23 -0000 Received: (qmail 19826 invoked by uid 22791); 21 Mar 2011 16:27:21 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 16:26:54 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2LGQnoK087537 ; Mon, 21 Mar 2011 17:26:49 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2LGQn0O084873 ; Mon, 21 Mar 2011 17:26:49 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2LGQmFR017858 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 21 Mar 2011 17:26:48 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Mark Kettenis'" Cc: , References: <000c01cbe7e0$53e3f510$fbabdf30$@muller@ics-cnrs.unistra.fr> <201103211612.p2LGCbYU010335@glazunov.sibelius.xs4all.nl> In-Reply-To: <201103211612.p2LGCbYU010335@glazunov.sibelius.xs4all.nl> Subject: RE: [RFC] Question about CODESET macro inside config/djgpp/langinfo.h Date: Mon, 21 Mar 2011 17:25:00 -0000 Message-ID: <000301cbe7e4$c66d4240$5347c6c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00963.txt.bz2 OK, then it is probably better to fix the=20 gdb_ari.sh script. Looking at the corresponding ARI rule, I think that the pattern to match FILENAME is wrong: @@ -983,7 +1011,7 @@ Call to set_gdbarch_" name # Count the number of times each tm/xm/nm macro is defined or undefined /^#[[:space:]]*(undef|define)[[:space:]]+[[:alnum:]_]+.*$/ \ && !/^#[[:space:]]*(undef|define)[[:space:]]+[[:alnum:]_]+_H($|[[:space:]])/ \ -&& FILENAME ~ /(^|\/)(config\/|tm-|xm-|nm-).*\.h$/ { +&& FILENAME ~ /(^|\/)config\/(|[^\/]*\/)(tm-|xm-|nm-).*\.h$/ { basename =3D gensub(/(^|.*\/)([^\/]*)$/, "\\2", 1, FILENAME) type =3D gensub(/^(tm|xm|nm)-.*\.h$/, "\\1", 1, basename) name =3D gensub(/^#[[:space:]]*(undef|define)[[:space:]]+([[:alnum:]_]+).*$/, "\\2", 1, $0) This patch removes config/djgpp/langinfo.h from=20 from the list of matches. Should I apply that change to gdb_ari.sh so that we can forget about CODESET macro once for all? Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Mark Kettenis > Envoy=E9=A0: lundi 21 mars 2011 17:13 > =C0=A0: pierre.muller@ics-cnrs.unistra.fr > Cc=A0: gdb-patches@sourceware.org; eliz@gnu.org > Objet=A0: Re: [RFC] Question about CODESET macro inside > config/djgpp/langinfo.h >=20 > > From: "Pierre Muller" > > Cc: "'Eli Zaretskii'" > > > > Also about macros removal inside config subdirectory: > > > > I was wondering about the usefulness of CODESET macro definition > > inside > > config/djgpp/langinfo.h > > > > #define CODESET CODESET > > > > while CODESET is itself a member of an enumeration. >=20 > It means that you can check for the macro using #ifdef. I think that > is required by POSIX.