From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13428 invoked by alias); 17 May 2010 17:34:40 -0000 Received: (qmail 13418 invoked by uid 22791); 17 May 2010 17:34:39 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 May 2010 17:34:33 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4HHXwJC052902 ; Mon, 17 May 2010 19:33:59 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o4HHXw9P031625 ; Mon, 17 May 2010 19:33:58 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4HHXvXg090758 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 17 May 2010 19:33:57 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" , "'Tom Tromey'" Cc: References: <8830.7035308846$1273670829@news.gmane.org> <20100517172758.GJ2805@adacore.com> In-Reply-To: <20100517172758.GJ2805@adacore.com> Subject: RE: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute Date: Mon, 17 May 2010 17:34:00 -0000 Message-ID: <000301caf5e7$222ac800$66805800$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00361.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Monday, May 17, 2010 7:28 PM > =C0=A0: Tom Tromey > Cc=A0: Pierre Muller; gdb-patches@sourceware.org > Objet=A0: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter > attribute >=20 > > Pierre> Should zero be considered as FALSE and > > Pierre> thus the should say that this parameter is NOT a variable > parameter, > > Pierre> or does the simple presence of this attribute condfirm > > Pierre> this it is a variable parameter, no matter the value of the > flag. > > Pierre> I took the first approach here, but have the impression > > Pierre> that it is not always the case inside dwarf2read.c code. > > > > I think you made the correct choice. >=20 > FWIW: I also double-checked the DWARF3 standard, and it says that the > value of this attribute is a flag, and following the hyperlinks in > the PDF, one gets to: >=20 > flag > A flag is represented as a single byte of data (DW_FORM_flag). > If the flag has value zero, it indicates the absence of the > attribute. If the flag has a non-zero value, it indicates the > presence of the attribute. So, may I commit this patch? Pierre