Re: [RFA] testsuite: avoid compilation error on cygwin/mingw if -nostdlib option is used.

Pedro Alves
2009-10-01T23:29:47Z

Seems reasonable. This is okay, with nits below.

On Thursday 01 October 2009 23:36:12, Pierre Muller wrote:

> + set add_unbuffered_object 1;
> + if {[lsearch -regexp $options ".*-nostdlib.*"] >= 0 } {
> + verbose "No set_unbuffered_mode for -nostdlib option";
> + set add_unbuffered_object 0;
> + }

The ';' are unnecessary. The '.*' are also unnecessary.

> if { $gdb_saved_set_unbuffered_mode_obj == "" } {
> verbose "compiling gdb_saved_set_unbuffered_obj"
> set unbuf_src ${srcdir}/lib/set_unbuffered_mode.c
> @@ -1824,7 +1881,9 @@ proc gdb_compile {source dest type optio
> # reverse link order. In that case, we can use ldflags to
> # avoid copying the object file to the host multiple
> # times.
> - lappend options "ldflags=$gdb_saved_set_unbuffered_mode_obj"
> + if { $add_unbuffered_object == 1 } {

Works too:

if { $add_unbuffered_object } {

Or, why not drop the extra variable, and just:

if {[lsearch -regexp $options "-nostdlib"] < 0 } {
lappend options "ldflags=$gdb_saved_set_unbuffered_mode_obj"
}

a suitable small comment would be nice too.

> + lappend options "ldflags=$gdb_saved_set_unbuffered_mode_obj"
> + }
> }
> }

--
Pedro Alves