From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sP1AFkwMi2FnZQAAWB0awg (envelope-from ) for ; Tue, 09 Nov 2021 19:03:24 -0500 Received: by simark.ca (Postfix, from userid 112) id 587981F0C1; Tue, 9 Nov 2021 19:03:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 826851EE14 for ; Tue, 9 Nov 2021 19:03:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 316193857C59 for ; Wed, 10 Nov 2021 00:03:23 +0000 (GMT) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id BB0FE3858031 for ; Wed, 10 Nov 2021 00:02:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB0FE3858031 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x1036.google.com with SMTP id j6-20020a17090a588600b001a78a5ce46aso207388pji.0 for ; Tue, 09 Nov 2021 16:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zIe4wDKW8JaTJL4eWpAY6E4M9mfAF0vzxX8JW/fr/S0=; b=pcaYu1SpO28mI8Byt8fowpgJgmSLK3XLrUDiwA81loNWJeMqEM4LF2Av3ahHf67Nq9 hhInAe9A53kinhJvt663cPRAziGDTO6c3zgbMfIZKynVNKsw+GO8REIV8D7qZSDbisps LkPRcO1TJGVQVg67eEE+24so8WmSFxP2iGRoloEvklqZFG6T3s0bBbYhvE4ab4JhNPcP sYHTfnTSz1dVVsIKhBh7vhHNLgGghjKn/f42mmaATP4jvho4ZRGRGO64y0nZdRu/bWXi 4VEqsypDMpx58KlLAAsSkFwLlGizrSyB2oWpygAvYHd2UTDrM5AM+HtKW6J6hBWo82+b Vs3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zIe4wDKW8JaTJL4eWpAY6E4M9mfAF0vzxX8JW/fr/S0=; b=pSNGn6s86TA/BLvbbboB6XG+WB/GpMKE/UJ3l7bIlWrvHv0SF9jifjv/1xQDO/R6TP vJeem4rDMzsMeVrHWrCsCLw5PCdyXU1VQwbZeIaznKlZNW25HyDMHJ8u+zZsClzsE0oH qV2BL8pVqgQ7vgeCqkiufMKHTwTI1p7GGCZzr3aXLeDM0FBiR65eReHFSJIt9fTNoDP0 xukP/3Yl56DDPoPx4FRJ5Uh5z/SA2p1lQTdVRb/t0lmxVSLzT3eEtMn9fDmoCZxkE/P1 DyK32E3Lmeu5+esMd4rTrlNxRZN5xxs+0pLXSiZNl6gLFCd4n0vNzDRwsqyWAmyHCabJ naBQ== X-Gm-Message-State: AOAM531iW/gfl4MYesY/0f646QFDQ7lUgTOERrJLIiHvot3eLOsfOftx f9sUwS+lHZAwlY+4AUMK7tChIu4JD5yd8VjzPZo= X-Google-Smtp-Source: ABdhPJxI5QmXrGVFa1ZLna46GtPhfijqKdXEmTpdJuspPNA8irferpd3sjaJCKvDkOylXBdMPoWuFg== X-Received: by 2002:a17:90b:1185:: with SMTP id gk5mr11954121pjb.113.1636502532908; Tue, 09 Nov 2021 16:02:12 -0800 (PST) Received: from [192.168.50.50] (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id ng9sm4129761pjb.4.2021.11.09.16.02.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 16:02:12 -0800 (PST) Subject: Re: [PATCH] sim: riscv: fix build breakage with rvv changes To: Vineet Gupta , gdb-patches@sourceware.org, binutils@sourceware.org References: <20211029192856.3987778-1-vineetg@rivosinc.com> From: Vineet Gupta Message-ID: <000176a6-2012-78ec-e89c-45c3908131e6@rivosinc.com> Date: Tue, 9 Nov 2021 16:02:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211029192856.3987778-1-vineetg@rivosinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dylan Reid , Kito Cheng Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" ping On 10/29/21 12:28 PM, Vineet Gupta wrote: > changes to gas for riscv vector extensions need to be propagated to sim > otherwise gdb fails to build on users/riscv/binutils-integration-branch > > This patch currently applies to that branch. > > Fixes: 144cceb058e "(RISC-V/rvv: Add rvv v0.10 instructions.)" > Reported-by: Dylan Reid > Signed-off-by: Vineet Gupta > --- > sim/riscv/ChangeLog-2021 | 4 ++++ > sim/riscv/sim-main.c | 3 ++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/sim/riscv/ChangeLog-2021 b/sim/riscv/ChangeLog-2021 > index e9aa74490f12..9ced6773bdd6 100644 > --- a/sim/riscv/ChangeLog-2021 > +++ b/sim/riscv/ChangeLog-2021 > @@ -1,3 +1,7 @@ > +2021-20-28 Vineet Gupta > + > + * sim-main.c (step_once): Fix match_func call per gas changes. > + > 2021-07-01 Mike Frysinger > > * configure: Regenerate. > diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c > index 0faf9395ae52..9b4f7c6c5aad 100644 > --- a/sim/riscv/sim-main.c > +++ b/sim/riscv/sim-main.c > @@ -956,6 +956,7 @@ void step_once (SIM_CPU *cpu) > sim_cia pc = cpu->pc; > const struct riscv_opcode *op; > int xlen = RISCV_XLEN (cpu); > + const char *error = NULL; > > if (TRACE_ANY_P (cpu)) > trace_prefix (sd, cpu, NULL_CIA, pc, TRACE_LINENUM_P (cpu), > @@ -985,7 +986,7 @@ void step_once (SIM_CPU *cpu) > for (; op->name; op++) > { > /* Does the opcode match? */ > - if (! op->match_func (op, iw)) > + if (! op->match_func (op, iw, 0, /* check_constraints */ &error)) > continue; > /* Is this a pseudo-instruction and may we print it as such? */ > if (op->pinfo & INSN_ALIAS) >