From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7808 invoked by alias); 27 Dec 2014 18:21:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7797 invoked by uid 89); 27 Dec 2014 18:21:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Dec 2014 18:21:44 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Sat, 27 Dec 2014 18:21:41 +0000 Received: from SHAWIN202 ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Sat, 27 Dec 2014 18:21:39 +0000 From: "Thomas Preud'homme" To: Subject: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute Date: Sat, 27 Dec 2014 18:21:00 -0000 Message-ID: <000101d02201$e9b4b430$bd1e1c90$@arm.com> MIME-Version: 1.0 X-MC-Unique: 114122718214100201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-12/txt/msg00642.txt.bz2 Hi there, By mistake a small gdb patch was commited while commiting the binutils patc= h to support value 3 of Tag_ABI_VFP_args ARM attribute because I forgot to = split the patch into two parts. My sincere apologize, this is my first binu= tils-gdb patch and the combined repository but double submission confused m= e. The patch is very straightforward so I hope it's not a problem but if it= is I'll promptly revert it of course. The following gdb change was commite= d: diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 43520cc..a917862 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -10007,27 +10007,34 @@ arm_gdbarch_init (struct gdbarch_info info, struc= t gdbarch_list *arches) OBJ_ATTR_PROC, Tag_ABI_VFP_args)) { - case 0: + case (int) AEABI_VFP_args_base: /* "The user intended FP parameter/result passing to conform to AAPCS, base variant". */ fp_model =3D ARM_FLOAT_SOFT_VFP; break; - case 1: + case (int) AEABI_VFP_args_vfp: /* "The user intended FP parameter/result passing to conform to AAPCS, VFP variant". */ fp_model =3D ARM_FLOAT_VFP; break; - case 2: + case (int) AEABI_VFP_args_toolchain: /* "The user intended FP parameter/result passing to conform to tool chain-specific conventions" - we don't know any such conventions, so leave it as "auto". */ break; + case (int) AEABI_VFP_args_compatible: + /* "Code is compatible with both the base + and VFP variants; the user did not permit + non-variadic functions to pass FP + parameters/results" - leave it as + "auto". */ + break; default: /* Attribute value not mentioned in the - October 2008 ABI, so leave it as + November 2012 ABI, so leave it as "auto". */ break; } The definition was added in include/elf/arm.h in the same commit as follows: diff --git a/include/elf/arm.h b/include/elf/arm.h index 34afdfd..e85536b 100644 --- a/include/elf/arm.h +++ b/include/elf/arm.h @@ -319,6 +319,23 @@ enum Tag_VFP_HP_extension =3D Tag_FP_HP_extension }; =20 +/* Values for Tag_ABI_FP_number_model. */ +enum +{ + AEABI_FP_number_model_none =3D 0, + AEABI_FP_number_model_ieee754_number =3D 1, + AEABI_FP_number_model_rtabi =3D 2, + AEABI_FP_number_model_ieee754_all =3D 3 +}; + +/* Values for Tag_ABI_VFP_args. */ +enum +{ + AEABI_VFP_args_base =3D 0, + AEABI_VFP_args_vfp =3D 1, + AEABI_VFP_args_toolchain =3D 2, + AEABI_VFP_args_compatible =3D 3 +}; #endif =20 /* The name of the note section used to identify arm variants. */ Please let me know if I should revert the patch and sorry again for the tro= uble. Best regards, Thomas