From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16363 invoked by alias); 26 Mar 2013 21:48:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16348 invoked by uid 89); 26 Mar 2013 21:48:04 -0000 X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT autolearn=no version=3.3.1 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 21:48:00 +0000 Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLlkkY097728 ; Tue, 26 Mar 2013 22:47:47 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLlks3021825 ; Tue, 26 Mar 2013 22:47:46 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLlikB020857 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 26 Mar 2013 22:47:45 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" , Cc: "'Corinna Vinschen'" References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> In-Reply-To: <20130319212554.GE4506@adacore.com> Subject: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling Date: Wed, 27 Mar 2013 04:59:00 -0000 Message-ID: <000101ce2a6b$8c855a60$a5900f20$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg00994.txt.bz2 Hi all, I get a failure for 32bit cygwin native GDB: make[1]: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb' gcc -gstabs+ -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/l ocale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../ src/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclara tion-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Werror -c -o windows-n at.o -MT windows-nat.o -MMD -MP -MF .deps/windows-nat.Tpo ../../src/gdb/windows-nat.c cc1: warnings being treated as errors ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string': ../../src/gdb/windows-nat.c:993:18: error: cast to pointer from integer of different size Makefile:972: recipe for target `windows-nat.o' failed make: *** [windows-nat.o] Error 1 make: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb' This failure can be fixed by this simple patch, which should not affect the unreleased 64-bit Cygwin, a confirmation by Corinna would be nice on this part... ChangeLog entry: 2013-03-26 Pierre Muller * windows-nat.c (handle_output_debug_string): Avoid typecast from integer of different size warning. Index: windows-nat.c =================================================================== RCS file: /cvs/src/src/gdb/windows-nat.c,v retrieving revision 1.245 diff -u -p -r1.245 windows-nat.c --- windows-nat.c 23 Mar 2013 10:48:23 -0000 1.245 +++ windows-nat.c 26 Mar 2013 21:39:57 -0000 @@ -990,7 +990,7 @@ handle_output_debug_string (struct targe retval = strtoul (p, &p, 0); if (!retval) retval = main_thread_id; - else if ((x = (LPCVOID) strtoull (p, NULL, 0)) + else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0)) && ReadProcessMemory (current_process_handle, x, &saved_context, __COPY_CONTEXT_SIZE, &n)