From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eR6XHS5IwGmXmTQAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 15:51:10 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=akZxFBo9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 73C061E0BC; Sun, 22 Mar 2026 15:51:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B07E41E08C for ; Sun, 22 Mar 2026 15:51:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 549BD4BAE7D6 for ; Sun, 22 Mar 2026 19:51:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 549BD4BAE7D6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=akZxFBo9 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by sourceware.org (Postfix) with ESMTPS id E8EEA4BB3B92; Sun, 22 Mar 2026 19:50:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8EEA4BB3B92 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=windriver.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8EEA4BB3B92 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774209030; cv=fail; b=sMwH/QMg1wuiYxgPniOApEEj2yjE8CutUuexLj8vCxM4vtJixFbjthSXqLD3QV/IV1EO4U5WJX3aA6LkXyrvCuCyRtCuPyQLCKWPrMIdMgbWBVU7wjEGgTNhEYNJtKDMUxGhhoUwAha3A92DFHDs267QBHTKQWRxnUHmKdLI2ug= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774209030; c=relaxed/simple; bh=leTztMVROKXTAzP027zjjvJS/ujZSUxGkgf0nySvSjo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=AFWdbyS/3DrsXqbEKVwPX9H72pQkyH7n6+IO9e124X+90/ZNhzmvz6QOh1tyvWVtSh9joJ9NWQTD0ZIoY+TjEPb5n7NWKJI1Gb3p/pKfTlARmktvQCyskxEXe7aUvpKybKHC/7VREXDnAgnMf9RKGnk6fQCQsE9iVrU4lJUnNUE= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8EEA4BB3B92 Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MJZ8ZC2871291; Sun, 22 Mar 2026 12:50:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=+hvzomWnkggxzrbasStDvm3XwVG6nFj4RnMFF9S85SI=; b= akZxFBo9ILEmM5rShHlptCrFM17dYgmVG+3+0s/jJrpBmD1I6m3dUg7lgsv3bbrA q5vcX0fC1r9xrjmYRvd4x6oVaTHBL0aPsK8fWfa8BhknDmGiara84pUOysGPN68a 90Cn002VCBxR+ME4fcvzsw7PbqXUld8itstmXjjlLA/sWAfpa71ASjscu7Ep7jlb g8AFlwAwIEwlbbSjacF+8OmC/b+qrvhxn7f1sGFJUAxlJhOjKxRYTPfC3/0Y6bxk 0BkYipeYmf7RpFXQ2/v/chXg3HcUOhZUO9FYNqaXnNdAgXtfSYBep6ejZ++ijJcb //DX3oOxIxOdE3JjbWpj5A== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11012025.outbound.protection.outlook.com [40.107.200.25]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4d1tucrv2u-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 22 Mar 2026 12:50:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Htg9Ve1dk0mZwPUpEI6JwsQAKMzEVmEeIIZY2KpRk9bxv5icwxCdBX3WJVIGx2NK/We6uzcuduTXOF47Ow5XUMFkK9eqx8CLBgIP/+Pgct8/iEGPwqg1BvtB1F1TWBGF9rjWsjgbuLd9UPhehuQml5niapizxqtcU+VTlRacvFRE9pcrUv0/JK4B6VqWxjo694oQ4K8niF1e+mHqx/5VQKUuhRxasGfFDNE84vBZ4bAC6xE40voO3kwBy2X9INgpQcSMU2o0OsxjUekjkWyxHP3cMIMLz2PHeEA4IwA9oItrpo2PotaasLvVvFab1WWu3PzpwmnPQ6sJqLSI/QY+iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hvzomWnkggxzrbasStDvm3XwVG6nFj4RnMFF9S85SI=; b=hXAo/mHhG7JyIrtayCJ+AdC5jj18vxSJ9E0SgRUkbwVNTUP5/rVX/f3Fbjs6UMWqdarUEd0Fo9cmrx+UHXSnKIqs4m36EwlxA7io4XCz8nN+PPTL6TWLQ+LZDH9sh0v2miIOXB6ymRabp8LQIjgiqPN48MXyr7g4SJilZfEBTTBRFo7LzG9SiK69wdmmmcaBqnkfwbN1Vwa3LUsaMBAAdZ4qDUhXbBMMLjIpSz35mE3pjjTLHca2I6FG9RyNOW9bJR6i+oxpGdD4LTtx/NQD77+aqTKBikwVVE+PpdhHQOXDJ7n5iz/6H2K9h9FVGQDczOhjOS786QEA3Di27Ftfjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) by SJ0PR11MB4862.namprd11.prod.outlook.com (2603:10b6:a03:2de::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.19; Sun, 22 Mar 2026 19:50:03 +0000 Received: from DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f]) by DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f%3]) with mapi id 15.20.9745.019; Sun, 22 Mar 2026 19:50:02 +0000 Message-ID: <00005783-e4a7-4521-8d0b-f6d05bd40dac@windriver.com> Date: Mon, 23 Mar 2026 01:19:54 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] PR gdb/33747: gdb/ser-unix: modernize Linux custom baud rate support To: Kevin Buettner Cc: gdb-patches@sourceware.org, macro@orcam.me.uk, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca References: <20260312210106.880833-1-sunilkumar.dora@windriver.com> <20260319154254.643d8e82@f42-zbm-amd> Content-Language: en-US From: Sunil Kumar Dora In-Reply-To: <20260319154254.643d8e82@f42-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MA5PR01CA0204.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1b0::16) To DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7901:EE_|SJ0PR11MB4862:EE_ X-MS-Office365-Filtering-Correlation-Id: 9acd7e81-0a01-409a-33c0-08de884c3515 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: t/u4H3SbD8eoEVKcEIRQXMlU4/CmdL9hWu3yKFxZ2VJ2rHcuzD5EEjIxxh2SLSL9mzNLPNZEOw0bLjyBeBmQOKdkwbXRltVQR6/aQMJhoRrC/LZaZhNJW183FbqE0CDi2J/qxf58M0LDj6QVIyby7VQgaF4MWvZStMQSMzL1ndV06/rcuPWLspWD7kEtKh74uUB3pcPtU3tAvsfErGl17dVobw16CGQhiY35hrNc31dZX/7UPcKWL19hI81JJVHjAdNRh8L7deKTw+kTJbHSUjat6MikEeGjpyF4t5EAn9570EyWEUU65mCTvQTEG1xT43Uf2/30ybDOLUSFexY4su7Zl6t2lm9fh40XSncZQ6lilKiPjU/9xuVeY8ltiEnPoe/00bnjpAt7MoMWOG1uv3rtr2adYiz9H6VAgKjJcyru0X20DZcyP3vKKpViRh6iMnHF+tysh0WrLdQBVJtSByB1xYh7yALui1h//MkJUQKQAxmGKXE0o5ICPXyD8mGrsfyS902NDpi1Q0WPRgwqlSw7WBkPjMhWQOf2bUdO6YWGygAkqnJekalyvjISwLKeFbqiZTfGr/oukck5iSrUvqSyOZvXJHmj6YFIZNyPWdjHXrnOTd1RRimt1mr7GgFjIn+JOpqN/G56F1VSExTy4/7yl8xgkMqEV9Dq9gkaquX0gIw+54UTnTIGhqzlnU8OyRu/ljcMzuqtuAMpcub8QKj4WhAqyzZSome0FUZ3U0Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXI3Umc3aFJnUG9CR1ZZTDV6L1dNSTdpU201aE9lREJBRUFFU3F5TWQwVHRu?= =?utf-8?B?V3hDM3VDZVVZNHFaMTdhRnZvNnk4NzJ6K2lwQ1VzL2plSzljb1pFeDhkVXRQ?= =?utf-8?B?WE41TmkzTm1JS1RHeS8rZWIwQS90WkN3Nm5uZTRydlJuMUhwYXFVcGFFV0hI?= =?utf-8?B?bUdVa2N6T2k4cEtoNDBQSCtlNG1DSXJwZG12NGZjcDQ5dklxTXFTcGhjaTNO?= =?utf-8?B?cE5RRm5UQjZycGVHaVVuUlFBcU5KQXUwaG1naGZucnFCYnpDeVZ3b3poeXZL?= =?utf-8?B?NVh3Vi9CNC9UOUJsYUYrUGhIOWc2dHpLRXpvWTZZWWw0WFJ2SmdvaEhzTnZa?= =?utf-8?B?VTFYbHFPVll1eDg5YU9LbDhESGo1M04wR2txUGpFTVhEek1ObVE4cXFKWmJV?= =?utf-8?B?TURUdkdURmhKZS9maElMbytFTDRXTVNIdDRZaUhwTEp4d1BEQTBuNEdFOC9K?= =?utf-8?B?WGVYUDJwdDJ6eVFra3JKUUFCMmdMWG5uM0lRVUl4YTN3V05jRnZnKzhoZEFt?= =?utf-8?B?R3pjYmR4RElHTGdRbzZEQU13NGxqQ0NlYldHT256N2xKTWZjRUZlek5LTERn?= =?utf-8?B?S3pYdHJpVXlSR0krd0pPQlNpU3U4WUdubm1mK015NHNvMXlKMTBDQVFFTFVu?= =?utf-8?B?cTc0OUg4ZEFQWlFCT2EvdUZZcExkcXQ0SDhGRlRIQWs4SHUydmowNXRQZVV2?= =?utf-8?B?WWNjQ0VwMGU5MnJ2ZTB6dEw5WlJuN3ZZT3RHYWFFTFI5N2JDbFdWcEhjRDZU?= =?utf-8?B?UzhIdFdLM2VlbHhzUE1lVXhqV0oxckhOWTNWc25DaWhsNENEWnBwR3hHeXoy?= =?utf-8?B?T0FXMGpJNHgwQWJ6dkYwb0E4RHNZSWsrMHRjdUF5TEZnTmw5U1I4WTdYZ3hP?= =?utf-8?B?WEh5ekpHck5oMWVnTUJsY0w0Q1V3Vkx0cmVRZkZwL2hURUZkM1cvT2dWdTNC?= =?utf-8?B?N0s0dVdZQ3FQQmhZanZRdTRuNW5MQmJxUW8wOUowS2VYN1BWUVdYb1FlOE4x?= =?utf-8?B?cGVBdlRPalZWTGVJb1NoQVZkR2Q4YVA5alBPaGZxNi9pYVlFd2xZRU5nM1Ns?= =?utf-8?B?QTV5Ky9qVW1TU0ppbTRCeTA2U2Q2U0xwelBTNW5hKzRmK0d0NHRwVUI1K3Mv?= =?utf-8?B?ZjBZVEZTRGw3OTdCMk9lb1BqTDBSUnVXUXQzQVVTME9ObDRYWDBXbmVSdUlP?= =?utf-8?B?SHFBRExDMVJBdzhHclZYUUUwVXhYMVpSK0tUTXFrajBxbkJ3VklYQ01MWVpD?= =?utf-8?B?cWVHLzJNNmhKYXEzNXlmczhBR2cwV0dnZDk0WWttVzB4VEQ4VFFnQnhOdHlV?= =?utf-8?B?RGI4ZStPeHBVUERpZkxlK0JOT3FLaGlZTUJHclhiUFAxNW5sTVJmSGt3YVdD?= =?utf-8?B?TC9WeXprRkVBMFRFTDdaaXNFUVNvSDBLTGRUaWRFYkorRXVDZldmekc1cVRo?= =?utf-8?B?V0NSeHNoQ24rZFRPclZ5UmFFVVgya2RHZm5UNXJna3ppTHpZdVBoS3FrRUJB?= =?utf-8?B?enRpMmozQnZpYzRFcVo3cTVZL3c5a3VkZkNsWm1HKzBvanRCOXljZGN0MmMr?= =?utf-8?B?SFVnbFFRUkNTNGJRZWJkbmJTb2Y1L0NhZkU0Q2hHZVBlMDNGeXJrT2JXb2tu?= =?utf-8?B?Yks4WGtxOXJlb0kzaHhvT0lSQVdnR1ZBNHNrV0hwYk9iMWNDSWdOM2xDbnh1?= =?utf-8?B?Q2xsZ2N3WUJPdzk0U3I5aloxb0Q0MFRtbkxlRXg3aXFDRXozU3QyQXZVczMz?= =?utf-8?B?Z3h3Zk5RTWE4MFhOZlc4WkJ1cWx2d1ZCc0J3RmlpVGZxNElXMkN1bmxpSC9a?= =?utf-8?B?UnkwNTZ5blZHMWhiWXFhajl6UEVMRzdSd3pobUNtR0NabDZkcDFrMmZRVE03?= =?utf-8?B?Mkp4RGlZWlgxRFNSN3hoejdaMTNFeUlIK3B0UmVlVjFjdzFDTjJRSVk2STRv?= =?utf-8?B?WE1MYjZrTG5lRk40ZlU1cjdVbk5nLzRja0pIOUdpbVI5di82MUtuTHRtOEdJ?= =?utf-8?B?RnBmN1lPcUxrOWFqdDBtZ1hETWVjVTk2VjRIMTFSYWpJZkVUZWoyaVBKdGM1?= =?utf-8?B?ei85ZXhFWUk5c2JnQ04zVFVzeWN1RTduRVZjZTlRNVNZLzZxeFhlMXBqMEo3?= =?utf-8?B?WGNDUG5acGlvbHVBMVdvWTlGUDVNSTNmZXZGSUgraFpKT2FOZ3AwN25GVGli?= =?utf-8?B?cHRpQ0QyOWxlZm9JZXZJZ2VnNU8yWEloemo1cWxDZnVETS9BTkRhaCtrTHJV?= =?utf-8?B?NkM4bXIyMkVvWFJiRFNuanRISnZqd2dZQWVLSlN3U3dGaGdEWStzVXpjZ0Np?= =?utf-8?B?Q0l3OEkvcGVtSEhORTFXTTRLdVZuL04yb3RNdEFFTWpJeHloZVd3RDNZdTVY?= =?utf-8?Q?9H+GCUSu3eGPUQIQ=3D?= X-Exchange-RoutingPolicyChecked: ng/CUfziXNfv3wmyTRGF6sFS3BMpJmkFFqLKmPWccxbm9pUoFdBuWBV3bRreKT/oqaDTd6oy4+UznDutvrOElq9qb0SALuxJBBGgoCO1lnEaBDTRq2rU50b4Gq+GLb4ZL+Weq0HfgJeXIB7AwRMvfl78uLxHoH072ssDJbJkfo0AEaEXrCJGRqGPCAIEwuHFUTQjGy1E/qoWNBePv6LIDV3crMy0+RbW0/eAK3xRFtNtAIIRZQJakpm5ZEy3RhTgeGq3D5rHTs4G+RQg9KJb70MvrSo6Fl0NHdetuStgHBYz4vxD1PvJHYlT/+Fne9OuDmPKXQH4u7Cj1T9BcHMF+Q== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9acd7e81-0a01-409a-33c0-08de884c3515 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2026 19:50:02.6681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w9vx63ePC8I3qW0QMAZr8zPUqUNSvK1JCallX2ZvOE6zFTZHCGXVqGT5zP0o56j6Komxk6byDPTzIm/ZLAKRU6NOMECoyGBztkKNJM0yRdw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4862 X-Proofpoint-GUID: o4B10B_efEDilFOBlVD0kuQ7EpvVGV4X X-Proofpoint-ORIG-GUID: o4B10B_efEDilFOBlVD0kuQ7EpvVGV4X X-Authority-Analysis: v=2.4 cv=deCNHHXe c=1 sm=1 tr=0 ts=69c047ed cx=c_pps a=USxXWJl8r5vV66mO10fP8A==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=xZde5rkvfhKswXZ7PkYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIyMDE3MiBTYWx0ZWRfX4KFdBGBTjEXI Pr0ZS6wWkpVrbcbkBVY8KeZmOL7dWHnSSkjdsqMUFOBIVVUrcPjJ4xTW9IimBRYkJe17axaJBki p9qJSjoreZFgi1B/DPXm6qwVTpbD1u0VXpQzGKQzeaJv29WsnGY54sEsFAwil4/8FQ1Tbb5xStb Ys63lxb8eDYvDYAnuhLyMThVj8sfXq+1FEMZ0cvYknspZmkMCur6EObcIMqq/TfHsPlyMcW3njo J4oqG8X7oqyDcXLv9sRbCqLLKFZjlyeige7FGgIS2yjy1P5rmVSP0erMWBveRvu19gUH1VR/ZgN fI/uATUNhdLBa2IosZ+VYfBRNieqwT57xTvGFeCAYAKq6WgNhx2g+4Dd3DdvJW1+NN1vVzO/WZ3 VwUQsi1M3kcdEK5TlVsgTlyOXwgspy2dv7pgiwtrWAF/ffpmklMvEpbXmGRV8+sb2RcsPwDjH5W pCUvczOdKv3/D6Absgg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-22_06,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603220172 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks Kevin. On 3/20/2026 4:14 AM, Kevin Buettner wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Thu, 12 Mar 2026 14:01:06 -0700 > sunilkumar.dora@windriver.com wrote: > >> diff --git a/gdb/ser-unix.c b/gdb/ser-unix.c >> index c295a9c5ba1..a15f4cc2162 100644 >> --- a/gdb/ser-unix.c >> +++ b/gdb/ser-unix.c >> @@ -510,36 +510,59 @@ set_baudcode_baudrate (struct serial *scb, int >> baud_code) >> #if HAVE_CUSTOM_BAUDRATE_SUPPORT && defined(BOTHER) >> >> -/* Set a custom baud rate using the termios BOTHER. */ >> +/* Set a custom baud rate. >> + >> + Prefer the POSIX cfsetispeed/cfsetospeed interface when it accepts >> + arbitrary baud rates. Otherwise fall back to Linux-specific termios2 >> + (BOTHER) or legacy termios interfaces. */ >> >> static void >> set_custom_baudrate_linux (int fd, int rate) >> { >> -#ifdef TCGETS2 >> - struct termios2 tio; >> - const unsigned long req_get = TCGETS2; >> - const unsigned long req_set = TCSETS2; >> -#else >> +#if defined(HAVE_CFSETSPEED_ARBITRARY) > Can you add a comment about how this code path is supported by glibc > 2.42+ ? You could also mention that this behavior is expected to be > standardized by a future POSIX revision. In V4:   - set_custom_baudrate_posix() has a comment added as suggested,     including the glibc 2.42+ support and future POSIX direction. > >> struct termios tio; >> - const unsigned long req_get = TCGETS; >> - const unsigned long req_set = TCSETS; >> -#endif >> + if (tcgetattr (fd, &tio) < 0) >> + perror_with_name (_("Cannot get current baud rate")); >> + >> + cfsetispeed (&tio, rate); >> + cfsetospeed (&tio, rate); > Return values for cfsetispeed and cfsetospeed should be checked. If > either call fails, it should either error out or try another way of > setting the speed. Return values of cfsetispeed() and cfsetospeed() are now checked, with perror_with_name() called on failure in V4. Thanks, Sunil Dora > > Kevin >