From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58776 invoked by alias); 8 Apr 2015 14:08:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58766 invoked by uid 89); 8 Apr 2015 14:08:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.216) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Apr 2015 14:08:04 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 3EE23141063; Wed, 8 Apr 2015 16:08:02 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 303D1141068; Wed, 8 Apr 2015 16:08:02 +0200 (CEST) Received: from lmr.u-strasbg.fr (lmr2.u-strasbg.fr [172.30.21.2]) by mr6.u-strasbg.fr (Postfix) with ESMTP id F3A19141063; Wed, 8 Apr 2015 16:07:58 +0200 (CEST) Received: from lmr.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id BB340B5; Wed, 8 Apr 2015 16:07:58 +0200 (CEST) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by lmr2.u-strasbg.fr (Postfix) with ESMTPSA id 4ABB4E3; Wed, 8 Apr 2015 16:07:55 +0200 (CEST) From: "Pierre Muller" To: "'Sergio Durigan Junior'" , "'Pedro Alves'" Cc: "'GDB Patches'" References: <1427241443-5939-1-git-send-email-sergiodj@redhat.com> <1427241443-5939-2-git-send-email-sergiodj@redhat.com> <5515289D.1000006@redhat.com> <874mp0vir0.fsf@redhat.com> In-Reply-To: <874mp0vir0.fsf@redhat.com> Subject: Build failure following: Implement support for checking /proc/PID/coredump_filter commit Date: Wed, 08 Apr 2015 14:08:00 -0000 Message-ID: <000001d07205$69de1770$3d9a4650$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-04/txt/msg00266.txt.bz2 Hi all, The approved patch "Implement support for checking /proc/PID/coredump_filter commit" committed April 1. 2015: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;a=3Dcommitdiff;h= =3Ddf84 11da087dc05481926f4c4a82deabc5bc3859 breaks mingw64 with --enable-targets=3Dall configure option. The reason is the introduction of strtok_r function in gdb/linux-tdep.c source. This function is not present in my version of x86_64-w64-mingw32 cross-system (on a Cygwin system). The function is found in string.h header on native Cygwin, but inside a conditional: /usr/include/string.h-46-#if __POSIX_VISIBLE /usr/include/string.h:47:char *_EXFUN(strtok_r,(char *__restrict, const char *__restrict, char **__restrict)); /usr/include/string.h-48-#endif I did not find any explicit inclusion of string header inside linux-tdep.c source... There is a workaround in mingw64 pthread.h: /usr/x86_64-w64-mingw32/sys-root/mingw/include/pthread.h:455:#ifndef strtok_r /usr/x86_64-w64-mingw32/sys-root/mingw/include/pthread.h:456:#define strtok_r(__s, __sep, __last) (*(__last) =3D strtok((__s), (__sep))) /usr/x86_64-w64-mingw32/sys-root/mingw/include/pthread.h-457-#endif Does this suggest that strtok_r is not a required string.h function? If yes, should this function be tested by configure... Or maybe we should use the gnulib version of strtok_r? I don't really know how to do this, but if someone can tell me, I can test the patch. Pierre Muller > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Sergio Durigan Junior > Envoy=E9=A0: mercredi 1 avril 2015 01:40 > =C0=A0: Pedro Alves > Cc=A0: GDB Patches > Objet=A0: Re: [PATCH 1/2] Implement support for checking > /proc/PID/coredump_filter >=20 > On Friday, March 27 2015, Pedro Alves wrote: >=20 > > OK. >=20 > Thanks, pushed both patches: >=20 > > df8411da087dc05481926f4c4a82deabc5bc3859 >=20 > -- > Sergio > GPG key ID: 0x65FC5E36 > Please send encrypted e-mail if possible > http://sergiodj.net/