From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'asmwarrior'" <asmwarrior@gmail.com>, <gdb@sourceware.org>
Cc: "'gdb-patches'" <gdb-patches@sourceware.org>
Subject: RE: [windows mingw]gdb cvs head build error in windows-nat.c
Date: Fri, 16 Dec 2011 17:20:00 -0000 [thread overview]
Message-ID: <000001ccbc16$74bae6d0$5e30b470$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <004501ccbc05$bc014540$3403cfc0$@muller@ics-cnrs.unistra.fr>
> -----Message d'origine-----
> De : gdb-owner@sourceware.org [mailto:gdb-owner@sourceware.org] De la part
> de Pierre Muller
> Envoyé : vendredi 16 décembre 2011 16:17
> À : 'asmwarrior'; gdb@sourceware.org
> Cc : 'gdb-patches'
> Objet : RE: [windows mingw]gdb cvs head build error in windows-nat.c
>
>
>
> > -----Message d'origine-----
> > De : gdb-owner@sourceware.org [mailto:gdb-owner@sourceware.org] De la part
> > de asmwarrior
> > Envoyé : vendredi 16 décembre 2011 15:34
> > À : gdb@sourceware.org
> > Objet : Re: [windows mingw]gdb cvs head build error in windows-nat.c
> >
> > On 2011-12-16 22:21, asmwarrior wrote:
> > > I build under MSYS+mingw
> > > Here is the build error:
> I confirm that this build failure also exists for cygwin native build.
> > This patch should fix the build error.
> >
> > gdb/windows-nat.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Any small patch that resolves a build failure
> (especially for a native target) should be considered
> as obvious and can thus be applied without
> the need to wait for approval by a global maintainers.
>
> But the patch should probably be sent to
> gdb-patches mailing list together with the used ChangeLog entry.
I realized that I was assuming that you had write access to gdb cvs directory...
If this is not the case, I can commit the change for you,
just tell me under which name you would like to be acknowledged in the ChangeLog
or if the below is OK for you.
Pierre Muller
ChangeLog entry:
2011-12-16 Pierre Muller <muller@ics.u-strasbg.fr> (obvious fix)
From asmwarrior <asmwarrior@gmail.com>
* windows-nat.c (cygwin_get_dr, cygwin_get_dr7): Add missing prototypes.
Index: windows-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/windows-nat.c,v
retrieving revision 1.221
diff -u -p -r1.221 windows-nat.c
--- windows-nat.c 14 Dec 2011 17:20:31 -0000 1.221
+++ windows-nat.c 16 Dec 2011 17:12:25 -0000
@@ -173,7 +173,9 @@ static void windows_kill_inferior (struc
static void cygwin_set_dr (int i, CORE_ADDR addr);
static void cygwin_set_dr7 (unsigned long val);
+static CORE_ADDR cygwin_get_dr (int i);
static unsigned long cygwin_get_dr6 (void);
+static unsigned long cygwin_get_dr7 (void);
static enum target_signal last_sig = TARGET_SIGNAL_0;
/* Set if a signal was received from the debugged process. */
next prev parent reply other threads:[~2011-12-16 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EEB53E4.3070207@gmail.com>
[not found] ` <4EEB56CE.6050908@gmail.com>
2011-12-16 15:17 ` Pierre Muller
2011-12-16 16:17 ` Pedro Alves
2011-12-16 17:20 ` Pierre Muller [this message]
2011-12-16 18:47 ` Pedro Alves
2011-12-16 19:59 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ccbc16$74bae6d0$5e30b470$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox