From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85176-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32646 invoked by alias); 14 Nov 2011 15:55:04 -0000
Received: (qmail 32588 invoked by uid 22791); 14 Nov 2011 15:55:01 -0000
X-SWARE-Spam-Status: No, hits=-0.4 required=5.0	tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mtaout03-winn.ispmail.ntl.com (HELO mtaout03-winn.ispmail.ntl.com) (81.103.221.49)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 15:54:48 +0000
Received: from know-smtpout-4.server.virginmedia.net ([62.254.123.2])          by mtaout03-winn.ispmail.ntl.com          (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP          id <20111114155443.HFVG15194.mtaout03-winn.ispmail.ntl.com@know-smtpout-4.server.virginmedia.net>;          Mon, 14 Nov 2011 15:54:43 +0000
Received: from [94.169.176.59] (helo=JonPC)	by know-smtpout-4.server.virginmedia.net with esmtp (Exim 4.63)	(envelope-from <jon@beniston.com>)	id 1RPyrr-0001l9-GK; Mon, 14 Nov 2011 15:54:43 +0000
From: "Jon Beniston" <jon@beniston.com>
To: "'Tom Tromey'" <tromey@redhat.com>,	"'Werner Almesberger'" <werner@almesberger.net>
Cc: <gdb-patches@sourceware.org>
References: <20111111233808.GA10815@ws> <m3ipmmso0v.fsf@fleche.redhat.com>
In-Reply-To: <m3ipmmso0v.fsf@fleche.redhat.com>
Subject: RE: [PATCH] 32 bit-ism in lm32-tdep.c (and some sloppy macros)
Date: Mon, 14 Nov 2011 15:55:00 -0000
Message-ID: <000001cca2e5$b4dfad30$1e9f0790$@beniston.com>
MIME-Version: 1.0
Content-Type: text/plain;	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00353.txt.bz2

Hi Tom,

 
> Werner> -#define LM32_IMM16(insn)        ((((long)insn & 0xffff) << 16) >>
> 16)
> [...]
> Werner> +#define LM32_IMM16(insn)        ((long) (int16_t) (insn))
> 
> I was a little surprised to find out we already use int16_t in gdb.
> Anyway, it seems that the macro would be more obvious as:
> 
> #define LM32_IMM16(insn) ((long) ((insn) & 0xffff))
> 
> WDYT?

I'm not sure that sign-extends?

Jon