From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: RE: [RFA/commit/doco] move handing of "set interactive-mode" to gdb_has_a_terminal
Date: Wed, 26 Jan 2011 15:21:00 -0000 [thread overview]
Message-ID: <000001cbbd47$1d831a50$58894ef0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20110121185746.GD2440@adacore.com>
Hi Joel,
I think your patch is good, but
it has an error:
in gdb_has_a_terminal function:
+ if (interactive_mode != AUTO_BOOLEAN_AUTO)
+ return interactive_mode = AUTO_BOOLEAN_TRUE;
+
The current code sets interactive_mode variable
to AUTO_BOOLEAN_TRUE, which happens to be zero,
and thus the function returns 0...
I suppose that the correct code should be:
+ if (interactive_mode != AUTO_BOOLEAN_AUTO)
+ return (interactive_mode == AUTO_BOOLEAN_TRUE);
+
There is also a small error in the ChangeLog:
> > (gdb_has_a_terminal): Add handling of the "iteractive-mode"
This should have "interactive-mode" instead of "iteractive-mode"
Pierre Muller
GDB pascal language maintainer
next prev parent reply other threads:[~2011-01-26 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 23:42 Joel Brobecker
2011-01-19 15:01 ` Eli Zaretskii
2011-01-19 17:27 ` Joel Brobecker
2011-01-20 0:46 ` Eli Zaretskii
2011-01-21 19:48 ` Joel Brobecker
2011-01-26 15:21 ` Pierre Muller [this message]
2011-01-31 3:15 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cbbd47$1d831a50$58894ef0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox