From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20638 invoked by alias); 1 Jun 2010 06:57:28 -0000 Received: (qmail 20629 invoked by uid 22791); 1 Jun 2010 06:57:27 -0000 X-SWARE-Spam-Status: No, hits=-0.1 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 06:57:22 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o516vJiU007576 for ; Tue, 1 Jun 2010 08:57:19 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o516vIdR065026 for ; Tue, 1 Jun 2010 08:57:18 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o516vG9j049893 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Tue, 1 Jun 2010 08:57:18 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> <20100527151730.GA483@ednor.casa.cgf.cx> <001201cafe4e$e885afa0$b9910ee0$@muller@ics-cnrs.unistra.fr> <20100530171041.GB8605@ednor.casa.cgf.cx> In-Reply-To: <20100530171041.GB8605@ednor.casa.cgf.cx> Subject: [RFC] windows-nat.c: New oddity after copy console information for new console patch. Date: Tue, 01 Jun 2010 06:57:00 -0000 Message-ID: <000001cb0157$ae2e6610$0a8b3230$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00000.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Christopher Faylor > Envoy=E9=A0: Sunday, May 30, 2010 7:11 PM > =C0=A0: gdb-patches@sourceware.org; Pierre Muller > Objet=A0: Re: [RFA] windows-nat.c: Copy console information for new > console >=20 > On Fri, May 28, 2010 at 12:16:59PM +0200, Pierre Muller wrote: > >> >> From Christopher Faylor > >> >> I actually thought fairly carefully about flags. If you have a > >> >> function > >> >> which controls console info, then the function should set the > flags > >> >> appropriately to deal with the console info. > >> > > >> > > >> > As you prefer, > >> >here is a new version that also takes DWORD *flags as parameter. > >> > I also tried to explain a little bit better > >> >what the function tries to do. > >> > >> Thanks. Looks good. I forgot to say: Thanks for doing this. It > >> looks like > >> a nice improvement. > > > > Hi Christopher, > > does this mean that you want to test it > >a little bit more before you give some more detailed > >review or should I understand this as an approval? >=20 > Wow. You like to go back and forth don't you? Not really, but I prefer to ask once more rather than doing something wrong. > Just apply it already. Applied yesterday... But I just noticed a strange, probably unwanted effect of my patch: I you debug a GUI application that starts its main window at default size, this size is now different depending on the state on the `new-console' switch: - if new-console is off, the default size is chosen by the system (probably as before my patch), - if new-console is on, the size of the start window will be forced by the settings of dwXSize and dwYSize fields of the STARTUPINFO structure together with the STARTF_USESIZE flag. Should we change this? We could condition the call to windows_set_console_info=20 on the fact that the executable to start is not a GUI application,=20 but I am not sure how to check this within GDB code. Suggestions most welcome, Pierre Muller Pascal language support maintainer for GDB =20=20