From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4690 invoked by alias); 13 May 2010 00:00:47 -0000 Received: (qmail 4680 invoked by uid 22791); 13 May 2010 00:00:45 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 May 2010 00:00:39 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4D00U1G036648 ; Thu, 13 May 2010 02:00:30 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o4D00TCt076385 ; Thu, 13 May 2010 02:00:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4D00RuQ097350 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 13 May 2010 02:00:28 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: , "'FPC Core Developer List'" References: <23651.5388860882$1273672053@news.gmane.org> In-Reply-To: Subject: RE: [RFC] dwarf debug information: Handle Free Pascal virtual table indexes Date: Thu, 13 May 2010 07:59:00 -0000 Message-ID: <000001caf22f$573694e0$05a3bea0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00268.txt.bz2 Tom,=20 you have to take into account that I know about nothing about DWARF :( > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Wednesday, May 12, 2010 9:49 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC] dwarf debug information: Handle Free Pascal virtual > table indexes >=20 > >>>>> "Pierre" =3D=3D Pierre Muller > writes: >=20 > Pierre> DW_AT_vtable_elem_location attribute a BLOCK consisting of > Pierre> a DW_OP_constu marker followed by a unsigned_leb128 value > Pierre> to indicate the offset within the virtual table of a virtual > Pierre> function. >=20 > By my reading, this is incorrect DWARF. Or is there more to the > expression than that? What do you exactly mean by expression here? =20 > If it is not possible to fix the compiler, then I would propose making > this conditional on language_pascal. >=20 > If there is more to the expression, then maybe decode_locdesc already > handles it and we just need to update the gate in dwarf2_add_member_fn. I could indeed replace the call read_unsigned_leb128 by a call to decode_locdesc using DW_BLK(attr) but this is still different from the other call to decode_locdesc=20 earlier in the same function, because context is not set in Free Pascal case. =20 It is possible probably to fix the compile once I understand clearly what is wrong... But anyhow, this patch would allow released versions to be read correctly. Pierre