From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22552 invoked by alias); 7 Jul 2009 22:30:15 -0000 Received: (qmail 22512 invoked by uid 22791); 7 Jul 2009 22:30:10 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 22:30:02 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n67MTfOQ081432 ; Wed, 8 Jul 2009 00:29:42 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n67MTfgm061636 ; Wed, 8 Jul 2009 00:29:41 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n67MTe8B032320 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 8 Jul 2009 00:29:40 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Ulrich Weigand'" , "'Keith Seitz'" Cc: , References: <001801c9ff01$5b1ae830$1150b890$@u-strasbg.fr> from "Pierre Muller" at Jul 07, 2009 02:49:24 PM <200907071526.n67FQIPu022540@d12av02.megacenter.de.ibm.com> In-Reply-To: <200907071526.n67FQIPu022540@d12av02.megacenter.de.ibm.com> Subject: RE: [RFC] Insight build problem: was [06/15] Per-breakpoint architecture support Date: Tue, 07 Jul 2009 22:30:00 -0000 Message-ID: <000001c9ff52$6b698b50$423ca1f0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00221.txt.bz2 > It's not particularly nice, but I'm OK with leaving it the way > it was for now ... Longer term we should find out why the > exported interfaces like set_breakpoint are not suitable for gdbtk, > and extend them if necessary. Keith, could you answer that question? I did not investigate that deeply, but the parameters of set_raw_breakpoint and set_breakpoint are quite different... > > @@ -4396,8 +4397,9 @@ static void free_bp_location (struct bp_ > > > > /* Helper to set_raw_breakpoint below. Creates a breakpoint > > that has type BPTYPE and has no locations as yet. */ > > +/* This function is used in gdbtk sources and thus can not be made > static. > > */ > > > > -static struct breakpoint * > > +struct breakpoint * > > set_raw_breakpoint_without_location (struct gdbarch *gdbarch, > > enum bptype bptype) > > { Whoops... Sorry about that :( > This chunk seems unnecessary; set_raw_breakpoint_without_location > was static before my patch as well. > > The rest is OK. Thanks, I committed the following: 2009-07-07 Pierre Muller * breakpoint.c (set_raw_breakpoint): Remove static modifier. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.412 diff -u -p -r1.412 breakpoint.c --- breakpoint.c 2 Jul 2009 17:21:05 -0000 1.412 +++ breakpoint.c 7 Jul 2009 22:16:58 -0000 @@ -105,7 +105,8 @@ static void break_command_1 (char *, int static void mention (struct breakpoint *); -static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch, +/* This function is used in gdbtk sources and thus can not be made static. */ +struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch, struct symtab_and_line, enum bptype); @@ -4396,6 +4397,7 @@ static void free_bp_location (struct bp_ /* Helper to set_raw_breakpoint below. Creates a breakpoint that has type BPTYPE and has no locations as yet. */ +/* This function is used in gdbtk sources and thus can not be made static. */ static struct breakpoint * set_raw_breakpoint_without_location (struct gdbarch *gdbarch, @@ -4480,7 +4482,7 @@ get_sal_arch (struct symtab_and_line sal prior to completing the initialization of the breakpoint. If this should happen, a bogus breakpoint will be left on the chain. */ -static struct breakpoint * +struct breakpoint * set_raw_breakpoint (struct gdbarch *gdbarch, struct symtab_and_line sal, enum bptype bptype) {