From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21738 invoked by alias); 17 Jun 2009 06:19:15 -0000 Received: (qmail 21722 invoked by uid 22791); 17 Jun 2009 06:19:14 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Jun 2009 06:19:07 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n5H6IsFa045849 ; Wed, 17 Jun 2009 08:18:54 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n5H6IsUj002090 ; Wed, 17 Jun 2009 08:18:54 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n5H6Iqu3038260 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 17 Jun 2009 08:18:53 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: , "'Eli Zaretskii'" References: <001401c9de9f$928b9f80$b7a2de80$@u-strasbg.fr> <200906170046.22746.pedro@codesourcery.com> <000f01c9eedd$c8823790$5986a6b0$@u-strasbg.fr> <200906170105.57436.pedro@codesourcery.com> In-Reply-To: <200906170105.57436.pedro@codesourcery.com> Subject: RE: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP Date: Wed, 17 Jun 2009 06:19:00 -0000 Message-ID: <000001c9ef13$7f51bc90$7df535b0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00431.txt.bz2 Committed, thanks. Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Wednesday, June 17, 2009 2:06 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org; 'Eli Zaretskii' > Objet=A0: Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP >=20 > On Wednesday 17 June 2009 00:54:26, Pierre Muller wrote: > > This is perfectly OK for me, > > could you check it in? > > Otherwise I can check it in tomorrow. >=20 > I've no hurry, check it in tomorrow then. ;-) >=20 > -- > Pedro Alves For the record, here is what I finally checked in. 2009-06-17 Pierre Muller Pedro Alves =09 * infcmd.c (post_create_inferior): Call breakpoint_re_set after target is pushed for watchpoint promotion to hardware watchpoint. =20 Index: infcmd.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.245 diff -u -p -r1.245 infcmd.c --- infcmd.c 7 Jun 2009 16:46:48 -0000 1.245 +++ infcmd.c 17 Jun 2009 05:58:47 -0000 @@ -421,6 +421,18 @@ post_create_inferior (struct target_ops=20 #endif } =20 + /* If the user sets watchpoints before execution having started, + then she gets software watchpoints, because GDB can't know which + target will end up being pushed, or if it supports hardware + watchpoints or not. breakpoint_re_set takes care of promoting + watchpoints to hardware watchpoints if possible, however, if this + new inferior doesn't load shared libraries or we don't pull in + symbols from any other source on this target/arch, + breakpoint_re_set is never called. Call it now so that software + watchpoints get a chance to be promoted to hardware watchpoints + if the now pushed target supports hardware watchpoints. */ + breakpoint_re_set (); + observer_notify_inferior_created (target, from_tty); } =20