From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29552 invoked by alias); 13 Feb 2009 08:42:34 -0000 Received: (qmail 29544 invoked by uid 22791); 13 Feb 2009 08:42:34 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Feb 2009 08:42:28 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n1D8g5GR046788 ; Fri, 13 Feb 2009 09:42:05 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n1D8g3Yx031008 ; Fri, 13 Feb 2009 09:42:03 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n1D8g2Df016982 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 13 Feb 2009 09:42:03 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" , "'Mark Kettenis'" , Cc: References: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr> <000401c98a88$afe4c2c0$0fae4840$@u-strasbg.fr> In-Reply-To: Subject: [RFA-v2] Use i386_use_watchpoints for go32v2, bds and windows native Date: Fri, 13 Feb 2009 11:06:00 -0000 Message-ID: <000001c98db6$f39851e0$dac8f5a0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0001_01C98DBF.555CB9E0" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00301.txt.bz2 Il s'agit d'un message ` parties multiples au format MIME. ------=_NextPart_000_0001_01C98DBF.555CB9E0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-length: 1156 I resubmitting an updated patch that takes into account the remark from Mark, that only FreeBSD supports hardware watchpoints. Eli already gave his approval for the go32 part, but I also need approval for bsd and for windows. This patch is required, in order for the hardware watchpoint patch for windows gdbserver, to be useful for windows native gdb debugger connected to a windows native gdbserver. http://sourceware.org/ml/gdb-patches/2009-02/msg00206.html But I didn't get any feedback on that RFC yet :( By the way, who is responsible for windows gdbserver? Mark and Chris, is this patch OK? Pierre Muller Pascal language support maintainer for GDB gdb/ChangeLog entry: 2009-02-13 Pierre Muller * Extend use of i386_use_watchpoints to all i386 native files using hardware watchpoints. go32-nat.c (init_go32_ops): Call i386_use_watchpoints. i386fbsd-nat.c (_initialize_i386fbsd_nat): Ditto. windows-nat.c (init_windows_ops): Ditto. config/i386/nm-cygwin.h: Define I386_WATCHPOINTS_IN_TARGET_VECTOR. config/i386/nm-cygwin64.h: Ditto. config/i386/nm-fbsd.h: Ditto. config/i386/nm-go32.h: Ditto. ------=_NextPart_000_0001_01C98DBF.555CB9E0 Content-Type: application/octet-stream; name="i386_use_watchpoints.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="i386_use_watchpoints.patch" Content-length: 5225 Index: gdb/go32-nat.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/go32-nat.c,v=0A= retrieving revision 1.63=0A= diff -u -p -r1.63 go32-nat.c=0A= --- gdb/go32-nat.c 6 Feb 2009 22:21:26 -0000 1.63=0A= +++ gdb/go32-nat.c 8 Feb 2009 22:27:44 -0000=0A= @@ -910,6 +910,9 @@ init_go32_ops (void)=0A= go32_ops.to_has_stack =3D 1;=0A= go32_ops.to_has_registers =3D 1;=0A= go32_ops.to_has_execution =3D 1;=0A= +=0A= + i386_use_watchpoints (&go32_ops);=0A= +=0A= go32_ops.to_magic =3D OPS_MAGIC;=0A= =20=0A= /* Initialize child's cwd as empty to be initialized when starting=0A= Index: gdb/i386fbsd-nat.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/i386fbsd-nat.c,v retrieving revision 1.16 diff -= u -p -r1.16 i386fbsd-nat.c=0A= --- gdb/i386fbsd-nat.c 3 Jan 2009 05:57:52 -0000 1.16=0A= +++ gdb/i386fbsd-nat.c 9 Feb 2009 12:32:57 -0000=0A= @@ -125,6 +125,7 @@ _initialize_i386fbsd_nat (void)=0A= =0A= /* Add some extra features to the common *BSD/i386 target. */=0A= t =3D i386bsd_target ();=0A= + i386_use_watchpoints (t);=0A= t->to_resume =3D i386fbsd_resume;=0A= t->to_pid_to_exec_file =3D fbsd_pid_to_exec_file;=0A= t->to_find_memory_regions =3D fbsd_find_memory_regions;=0A= Index: gdb/windows-nat.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/windows-nat.c,v=0A= retrieving revision 1.179=0A= diff -u -p -r1.179 windows-nat.c=0A= --- gdb/windows-nat.c 6 Feb 2009 22:21:26 -0000 1.179=0A= +++ gdb/windows-nat.c 8 Feb 2009 22:27:46 -0000=0A= @@ -2135,6 +2135,8 @@ init_windows_ops (void)=0A= windows_ops.to_has_registers =3D 1;=0A= windows_ops.to_has_execution =3D 1;=0A= windows_ops.to_pid_to_exec_file =3D windows_pid_to_exec_file;=0A= + i386_use_watchpoints (&windows_ops);=0A= +=0A= windows_ops.to_magic =3D OPS_MAGIC;=0A= }=0A= =20=0A= Index: gdb/config/i386/nm-cygwin.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/config/i386/nm-cygwin.h,v=0A= retrieving revision 1.8=0A= diff -u -p -r1.8 nm-cygwin.h=0A= --- gdb/config/i386/nm-cygwin.h 3 Jan 2009 05:57:54 -0000 1.8=0A= +++ gdb/config/i386/nm-cygwin.h 8 Feb 2009 22:27:46 -0000=0A= @@ -20,6 +20,7 @@=0A= void dll_symbol_command (char *, int);=0A= =20=0A= #define I386_USE_GENERIC_WATCHPOINTS=0A= +#define I386_WATCHPOINTS_IN_TARGET_VECTOR=0A= =20=0A= #include "i386/nm-i386.h"=0A= =20=0A= Index: gdb/config/i386/nm-cygwin64.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/config/i386/nm-cygwin64.h,v=0A= retrieving revision 1.1=0A= diff -u -p -r1.1 nm-cygwin64.h=0A= --- gdb/config/i386/nm-cygwin64.h 11 Jan 2009 13:15:56 -0000 1.1=0A= +++ gdb/config/i386/nm-cygwin64.h 8 Feb 2009 22:27:46 -0000=0A= @@ -19,6 +19,7 @@=0A= void dll_symbol_command (char *, int);=0A= =20=0A= #define I386_USE_GENERIC_WATCHPOINTS=0A= +#define I386_WATCHPOINTS_IN_TARGET_VECTOR=0A= =20=0A= #include "i386/nm-i386.h"=0A= =20=0A= Index: gdb/config/i386/nm-fbsd.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/config/i386/nm-fbsd.h,v=0A= retrieving revision 1.18=0A= diff -u -p -r1.18 nm-fbsd.h=0A= --- gdb/config/i386/nm-fbsd.h 3 Jan 2009 05:57:54 -0000 1.18=0A= +++ gdb/config/i386/nm-fbsd.h 8 Feb 2009 22:27:46 -0000=0A= @@ -23,6 +23,7 @@=0A= =20=0A= #ifdef HAVE_PT_GETDBREGS=0A= #define I386_USE_GENERIC_WATCHPOINTS=0A= +#define I386_WATCHPOINTS_IN_TARGET_VECTOR=0A= #endif=0A= =20=0A= #include "i386/nm-i386.h"=0A= Index: gdb/config/i386/nm-go32.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/gdb/config/i386/nm-go32.h,v=0A= retrieving revision 1.8=0A= diff -u -p -r1.8 nm-go32.h=0A= --- gdb/config/i386/nm-go32.h 3 Jan 2009 05:57:54 -0000 1.8=0A= +++ gdb/config/i386/nm-go32.h 8 Feb 2009 22:27:46 -0000=0A= @@ -18,6 +18,7 @@=0A= along with this program. If not, see . = */=0A= =20=0A= #define I386_USE_GENERIC_WATCHPOINTS=0A= +#define I386_WATCHPOINTS_IN_TARGET_VECTOR=0A= =20=0A= #include "i386/nm-i386.h"=0A= =20=0A= ------=_NextPart_000_0001_01C98DBF.555CB9E0--