From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24539 invoked by alias); 9 Feb 2009 12:34:26 -0000 Received: (qmail 24527 invoked by uid 22791); 9 Feb 2009 12:34:26 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Feb 2009 12:34:18 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n19CYERM003809 ; Mon, 9 Feb 2009 13:34:15 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n19CYEhP010842 ; Mon, 9 Feb 2009 13:34:14 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n19CYEq9071797 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 9 Feb 2009 13:34:14 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Mark Kettenis'" Cc: References: <000001c98a44$29b02a30$7d107e90$@u-strasbg.fr> <200902091106.n19B6sLe015739@brahms.sibelius.xs4all.nl> In-Reply-To: <200902091106.n19B6sLe015739@brahms.sibelius.xs4all.nl> Subject: RE: [RFA] Use i386_use_watchpoints for go32v2, bds and windows native Date: Mon, 09 Feb 2009 12:34:00 -0000 Message-ID: <000001c98ab2$bcf2f2a0$36d8d7e0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00203.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Mark Kettenis > Envoy=E9=A0: Monday, February 09, 2009 12:07 PM > =C0=A0: muller@ics.u-strasbg.fr > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Use i386_use_watchpoints for go32v2, bds and windows > native >=20 > > From: "Pierre Muller" > > Date: Mon, 9 Feb 2009 00:22:50 +0100 > > > > ChangeLog entry: > > > > 2009-02-08 Pierre Muller > > > > * Extend use of i386_use_watchpoints to all i386 native files > > using hardware watchpoints. > > go32-nat.c (init_go32_ops): Call i386_use_watchpoints. > > i386bsd-nat.c (i386bsd_target): Ditto. > > windows-nat.c (init_windows_ops): Ditto. > > config/i386/nm-cygwin.h: Define > I386_WATCHPOINTS_IN_TARGET_VECTOR. > > config/i386/nm-cygwin64.h: Ditto. > > config/i386/nm-fbsd.h: Ditto. > > config/i386/nm-go32.h: Ditto. >=20 > Only FreeBSD has hardware watchpoint support, so your change to > i386bsd-nat.c isn't quite right. I didn't manage to figure that out, thanks. This means that I should move the i386bsd-nat.c change to i386fbsd-nat.c source file. Would the part below be OK then? Pierre Muller Pascal language support maintainer for GDB Index: gdb/i386fbsd-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/i386fbsd-nat.c,v retrieving revision 1.16 diff -u -p -r1.16 i386fbsd-nat.c --- gdb/i386fbsd-nat.c 3 Jan 2009 05:57:52 -0000 1.16 +++ gdb/i386fbsd-nat.c 9 Feb 2009 12:32:57 -0000 @@ -125,6 +125,7 @@ _initialize_i386fbsd_nat (void) /* Add some extra features to the common *BSD/i386 target. */ t =3D i386bsd_target (); + i386_use_watchpoints (t); t->to_resume =3D i386fbsd_resume; t->to_pid_to_exec_file =3D fbsd_pid_to_exec_file; t->to_find_memory_regions =3D fbsd_find_memory_regions; Pierre@d620-muller ~/gdbcvs/src $ cvs diff -up gdb/i386* gdb/config/i386/nm-fbsd.h Index: gdb/i386fbsd-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/i386fbsd-nat.c,v retrieving revision 1.16 diff -u -p -r1.16 i386fbsd-nat.c --- gdb/i386fbsd-nat.c 3 Jan 2009 05:57:52 -0000 1.16 +++ gdb/i386fbsd-nat.c 9 Feb 2009 12:33:18 -0000 @@ -125,6 +125,7 @@ _initialize_i386fbsd_nat (void) /* Add some extra features to the common *BSD/i386 target. */ t =3D i386bsd_target (); + i386_use_watchpoints (t); t->to_resume =3D i386fbsd_resume; t->to_pid_to_exec_file =3D fbsd_pid_to_exec_file; t->to_find_memory_regions =3D fbsd_find_memory_regions; Index: gdb/config/i386/nm-fbsd.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/config/i386/nm-fbsd.h,v retrieving revision 1.18 diff -u -p -r1.18 nm-fbsd.h --- gdb/config/i386/nm-fbsd.h 3 Jan 2009 05:57:54 -0000 1.18 +++ gdb/config/i386/nm-fbsd.h 9 Feb 2009 12:33:18 -0000 @@ -23,6 +23,7 @@ #ifdef HAVE_PT_GETDBREGS #define I386_USE_GENERIC_WATCHPOINTS +#define I386_WATCHPOINTS_IN_TARGET_VECTOR #endif #include "i386/nm-i386.h"