From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20949 invoked by alias); 22 Oct 2008 09:40:22 -0000 Received: (qmail 20935 invoked by uid 22791); 22 Oct 2008 09:40:20 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Oct 2008 09:39:41 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m9M9daD3048779 ; Wed, 22 Oct 2008 11:39:37 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402::141]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m9M9daC7071966 ; Wed, 22 Oct 2008 11:39:36 +0200 (CEST) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id m9M9dZko030646 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 22 Oct 2008 11:39:36 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Denis PILAT'" , "'gdb-patches'" References: <48FC4417.2030807@st.com> In-Reply-To: <48FC4417.2030807@st.com> Subject: RE: Mingw gdb validation Date: Wed, 22 Oct 2008 09:40:00 -0000 Message-ID: <000001c9342a$189a83a0$49cf8ae0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::152]); Wed, 22 Oct 2008 11:39:37 +0200 (CEST) X-Virus-Status: Clean Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00536.txt.bz2 I thought about this a while ago also, and I was wondering if the best solution would not be to have a global nl variable defined in gdb.exp that would depend on the target you are testing. I also thought at that time that we should define two global variables: nl and nls. "nl" as being something that is a single newline defined generally as "\[\r\n\]" but probably as "\[\r\n\]\n?" for mingw32 and "nls" if more than one newline is allowed and should generally be simply "\[\r\n\]*" Once these two variables are set in gdb.exp, we should replace every "\[\r\n\]*" by a "$nls" and all \[\r\n\]" by "$nl" in the expected answer part of the tests. This should allow a lot of currently failing mingw32 test to succeed. It would also have the advantage of not changing anything for other targets, unless we find other targets that would benefit from a similar change, but that could then also be inserted in gdb.exp special cases for nl and nls variables. Nevertheless, changing all tests to use nl and nls is probably not an easy task... Pierre Muller Pascal language support maintainer for GDB