From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27366 invoked by alias); 4 Jul 2008 22:56:01 -0000 Received: (qmail 27337 invoked by uid 22791); 4 Jul 2008 22:55:58 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Jul 2008 22:54:31 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m64MqI1x020788 ; Sat, 5 Jul 2008 00:52:18 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402::141]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m64MqIlC004381 ; Sat, 5 Jul 2008 00:52:18 +0200 (CEST) Received: from d620muller ([130.79.244.149]) by mailserver.u-strasbg.fr (8.13.8/jtpda-5.5pre1) with ESMTP id m64MqE4k052320 ; Sat, 5 Jul 2008 00:52:18 +0200 (CEST) From: "Pierre Muller" To: "'Joel Brobecker'" , "'Eli Zaretskii'" Cc: References: <000001c8dbc2$b1d7afe0$15870fa0$@u-strasbg.fr> <20080704061700.GB18019@adacore.com> In-Reply-To: <20080704061700.GB18019@adacore.com> Subject: RE: [RFA] use filename_completer for add_setshow_optional_filename_cmd Date: Fri, 04 Jul 2008 22:56:00 -0000 Message-ID: <000001c8de28$9f5eafe0$de1c0fa0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::151]); Sat, 05 Jul 2008 00:52:18 +0200 (CEST) X-Virus-Status: Clean Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00063.txt.bz2 I have committed this patch together with the NEWS=20 entry, approved by Eli. Thanks to Joel and Eli, Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Friday, July 04, 2008 8:17 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] use filename_completer for > add_setshow_optional_filename_cmd >=20 > > There are currently only three adffected commands: > > > > "set debug-file-directory" > > "set args" > > "set solib-search-path" > > > > Only the second one might be questionable, but I also find that it > > is reasonable to have filename completion for "set args" as this is > > now done on most shells. >=20 > I also agree that this is more useful than completing on symbols. >=20 > > 2008-07-01 Pierre Muller > > > > cli/cli-decode.c (add_setshow_optional_filename_cmd): Set > > completer for set to filename_completer. >=20 > This change makes sense. Can you submit a NEWS entry describing the > new completion policy? The code update itself is approved. >=20 > Thank you, > -- > Joel