RE: [RFA] ARI fix: Remove 3 uses of xasprintf

["Pierre Muller" <muller@ics.u-strasbg.fr>]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of 'Daniel Jacobowitz'
> Sent: Monday, October 15, 2007 5:14 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org; 'Ulrich Weigand'
> Subject: Re: [RFA] ARI fix: Remove 3 uses of xasprintf
> 
> On Mon, Oct 15, 2007 at 05:06:05PM +0200, Pierre Muller wrote:
> >   It seems that both functions are still
> > used in gdbtk directory.
> >
> >   Is this directory still used?
> >
> >   I tried
> > 'make insight.exe' (cygwin system).
> > which compiled fine, but
> > ./insight resulted in "Interpreter `insight' unrecognized"
> 
> You have to build a bit more than that to get Insight; it needs top
> level TCL / Tk, for instance.  Yes, the gdbtk directory is still used.
> You could ask the insight developers to update, or just leave the
> definitions.

  Then I would simply leave it inside defs.h and utils.c
and ask you to apply this little patch to gdb_ari.sh

Pseudo ChangeLog:

2007-10-15  Pierre Muller  <muller@ics.u-strasbg.fr>
        * gdb_ari.sh (xasprintf): Add known entries in defs.h and utils.c.
        Switch to regression category.
        (xvasprintf): Idem.


$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.75
diff -u -p -r1.75 gdb_ari.sh
--- gdb_ari.sh  10 Oct 2007 11:56:14 -0000      1.75
+++ gdb_ari.sh  15 Oct 2007 15:36:09 -0000
@@ -1300,7 +1300,9 @@ Do not use vasprintf(), instead use xstr

 BEGIN { doc["xasprintf"] = "\
 Do not use xasprintf(), instead use xstrprintf"
-    category["xasprintf"] = ari_code
+    fix("xasprintf", "gdb/defs.h", 1)
+    fix("xasprintf", "gdb/utils.c", 1)
+    category["xasprintf"] = ari_regression
 }
 /(^|[^_[:alnum:]])xasprintf[[:space:]]*\(/ {
     fail("xasprintf")
@@ -1308,7 +1310,9 @@ Do not use xasprintf(), instead use xstr

 BEGIN { doc["xvasprintf"] = "\
 Do not use xvasprintf(), instead use xstrvprintf"
-    category["xvasprintf"] = ari_code
+    fix("xvasprintf", "gdb/defs.h", 1)
+    fix("xvasprintf", "gdb/utils.c", 1)
+    category["xvasprintf"] = ari_regression
 }
 /(^|[^_[:alnum:]])xvasprintf[[:space:]]*\(/ {
     fail("xvasprintf")



> > > 2007-10-15  Pierre Muller  <muller@ics.u-strasbg.fr>
> > >
> > > 	* cp-abi.c (set_cp_abi_as_auto_default): ARI fix:
> > > 	Replace xasprintf by xstrprintf.
> > > 	sysfile-mem.c (add_vsyscall_page): Ditto.
> 
> OK.
Thanks, committed,
after correcting sysfile-mem.c to symfile-mem.c which is the correct source
name...


Pierre