From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28273 invoked by alias); 10 Oct 2007 08:09:12 -0000 Received: (qmail 28264 invoked by uid 22791); 10 Oct 2007 08:09:11 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 10 Oct 2007 08:09:08 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id CBA29187020; Wed, 10 Oct 2007 10:13:47 +0200 (CEST) From: "Pierre Muller" To: "'Daniel Jacobowitz'" Cc: Subject: [RFA] gdb_ari.sh patch to eliminate wrong critical errors Date: Wed, 10 Oct 2007 09:07:00 -0000 Message-ID: <000001c80b14$db947450$92bd5cf0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00227.txt.bz2 strerror and floatformat_to_double are two entries at top of ARI web pages shown as critical regressions, but which are due to changes in the implementations of their substitutes. See http://sourceware.org/gdb/current/ari/ This patch fixes removes three entries: 1) strerror 2 Do not use strerror(), instead use safe_strerror() 2) floatformat to double 1 Do not use floatformat_to_double() from libierty, instead use floatformat_to_doublest() 3) gdb/utils.c missing strerror appearing in that order in the Critical section. I tested this locally and it does reduce the number of critical entries to 4. Daniel, could you please commit this? Remaining problems are: 1) inline 9 Do not use the inline attribute; since the compiler generally ignores this, better algorithm selection is needed to improved performance This problem is limited to three files: vec.c (1) vec.h (7) and xtensa-tdep.c (1). It could be easily removed, but I was wondering if there was a special reason why vec.h had some many. 2) GNU/Linux 4 Do not use `Linux', instead use `Linux kernel' or `GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word `Linux' appears on the same line as the word `GNU' or `kernel' This one is a little too subtle for me, as I am hardly able to distinguish between 'GNU/Linux system' and 'Linux kernel'... 3) hash 3 Do not use ` #...', instead use `#...' (some compilers only correctly parse a C preprocessor directive when `#' is the first character on the line) This 3 appearances are in: ada-lex.c (2) and xtensa-tdep.c (1) But ada-lex.c is an automatically generated file, and I am even wondering why this file is checked. 4) obsolete system 2 No config file for system These 2 entries are configure.host and configure.tgt which are again generated files... Pierre Muller ChangeLog pseudo-entry: 2007-10-10 Pierre Muller * gdb_ari.sh (strerror): update rule to reflect implementation of safe_strerror in posix-hdep.c and mingw-hdep.c. (floatformat_to_double): update rule to accept call in gdb/doublest.c source. $ cvs diff -up gdb_ari.sh Index: gdb_ari.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.74 diff -u -p -r1.74 gdb_ari.sh --- gdb_ari.sh 8 Oct 2007 12:01:35 -0000 1.74 +++ gdb_ari.sh 10 Oct 2007 07:54:54 -0000 @@ -488,7 +488,8 @@ BEGIN { doc["strerror"] = "\ Do not use strerror(), instead use safe_strerror()" category["strerror"] = ari_regression fix("strerror", "gdb/gdb_string.h", 1) - fix("strerror", "gdb/utils.c", 1) + fix("strerror", "gdb/mingw-hdep.c", 1) + fix("strerror", "gdb/posix-hdep.c", 1) } /(^|[^_[:alnum:]])strerror[[:space:]]*\(/ { fail("strerror") @@ -989,6 +990,7 @@ get_frame_locals_address, or get_frame_a BEGIN { doc["floatformat_to_double"] = "\ Do not use floatformat_to_double() from libierty, \ instead use floatformat_to_doublest()" + fix("floatformat_to_double", "gdb/doublest.c", 1) category["floatformat_to_double"] = ari_regression } /(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ { Pierre Muller