From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove gdbarch parameter of lookup_typename
Date: Thu, 05 Dec 2019 18:47:00 -0000 [thread overview]
Message-ID: <fcc00201-448d-c4d1-17ea-465d1e85e472@polymtl.ca> (raw)
In-Reply-To: <87sgly96or.fsf@tromey.com>
On 2019-12-05 9:40 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> I noticed that the gdbarch parameter of lookup_typename was unused, so I
> Simon> removed it (as well as from lookup_signed_typename and
> Simon> lookup_unsigned_typename) and updated all callers.
>
> This looks fine to me. Thanks for doing this.
>
> I do wonder a bit why the parameter was there in the first place. Maybe
> this code used to look at the per-arch types?
>
> Tom
>
I looked up the commit that removed the use of gdbarch, here it is:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1994afbf19892c9e614a034fbf1a5233e9addce3
This seems to be the corresponding message on gdb-patches:
https://sourceware.org/ml/gdb-patches/2014-12/msg00521.html
It looks like the series may have been pushed as one squashed commit?
Anyway, it looks indeed like were looking up primitive types using the gdbarch
before, I can't explain why that changed without digging deeper, but I'll suppose
that change was correct.
I will push the patch as soon as I confirmed it's still building.
Simon
prev parent reply other threads:[~2019-12-05 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 5:09 Simon Marchi
2019-12-05 14:40 ` Tom Tromey
2019-12-05 18:47 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcc00201-448d-c4d1-17ea-465d1e85e472@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox