From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes.
Date: Thu, 07 Feb 2013 21:32:00 -0000 [thread overview]
Message-ID: <87txpnu7xv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5110F64C.2040907@redhat.com> (Phil Muldoon's message of "Tue, 05 Feb 2013 12:08:44 +0000")
>> Right now, though. -stack-list-frames doesn't take any options.
>> I think it would be better if commands like this were converted to use
>> mi_getopt instead of doing the parsing by hand.
>> So I suggest having all the functions use a short option name.
>>
>> I think the changes like in -stack-list-locals are strange, too, in that
>> they make options order-dependent. This will be surprising to users.
Phil> I spent the last couple of weeks trying to fix this, and I have
Phil> reached a dead end with your review requirements.
Ok.
Phil> This is all somewhat tangential to the frame filters patch. While I
Phil> do not mind fixing issues as I go, this is becoming an issue far more
Phil> contentious than the patch content.
Phil> What do you think we should do?
For commands like -stack-list-frames, where the additions are new, use
mi_getopt. For existing commands with bogus argument handling, just do
whatever you can that makes sense.
Tom
next prev parent reply other threads:[~2013-02-07 21:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 14:31 Phil Muldoon
2012-12-05 17:11 ` Tom Tromey
2012-12-07 13:56 ` Phil Muldoon
2012-12-10 21:03 ` Tom Tromey
2013-02-05 12:08 ` Phil Muldoon
2013-02-07 21:32 ` Tom Tromey [this message]
2013-02-20 15:17 ` Phil Muldoon
2013-02-20 20:37 ` Tom Tromey
2013-03-11 22:13 Phil Muldoon
2013-03-12 20:43 ` Tom Tromey
2013-03-12 20:52 ` Phil Muldoon
2013-03-13 12:15 ` Phil Muldoon
2013-03-13 17:48 ` Tom Tromey
2013-03-13 19:41 ` Phil Muldoon
2013-03-13 20:27 ` Tom Tromey
2013-03-13 20:53 ` Phil Muldoon
2013-03-13 20:56 ` Tom Tromey
2013-03-13 21:10 ` Phil Muldoon
2013-03-14 17:54 ` Tom Tromey
2013-03-14 19:35 ` Phil Muldoon
2013-04-22 16:01 Phil Muldoon
2013-04-26 11:19 ` Tom Tromey
2013-05-06 8:23 Phil Muldoon
2013-05-06 20:42 ` Tom Tromey
2013-05-07 8:23 ` Phil Muldoon
2013-05-07 14:02 ` Tom Tromey
2013-05-08 10:18 ` Phil Muldoon
2013-05-08 19:47 ` Tom Tromey
2013-05-10 10:45 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txpnu7xv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox