From: Tom Tromey <tom@tromey.com>
To: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] gdb: Remove workaround for the vCont packet
Date: Fri, 14 Jan 2022 12:42:20 -0700 [thread overview]
Message-ID: <87tue6f6jn.fsf@tromey.com> (raw)
In-Reply-To: <20220113152118.1465255-4-christina.schimpe@intel.com> (Christina Schimpe via Gdb-patches's message of "Thu, 13 Jan 2022 16:21:18 +0100")
>>>>> ">" == Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:
>> The workaround for the vCont packet is no longer required due to the
>> former commit "gdb: Make global feature array a per-remote target array".
>> The vCont packet is now checked once when the connection is started and
>> the supported vCont actions are set to the target's remote state
>> attribute.
Thank you for the patch.
>> + /* Check vCont support and set the remote state's vCont_action_support
>> + attribute. */
>> + remote_vcont_probe ();
>> - if (m_features.packet_support (PACKET_vCont) == PACKET_SUPPORT_UNKNOWN)
>> - remote_vcont_probe ();
It seems like the new code should probably check whether the packet is
supported like the old code did, in case the gdb user disabled it using
the appropriate "set remote" command.
Tom
next prev parent reply other threads:[~2022-01-14 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 15:21 [PATCH 0/3] Apply fixme notes for multi-target support Christina Schimpe via Gdb-patches
2022-01-13 15:21 ` [PATCH 1/3] gdb: Make global feature array a per-remote target array Christina Schimpe via Gdb-patches
2022-01-14 19:30 ` Tom Tromey
2022-01-20 16:32 ` Schimpe, Christina via Gdb-patches
2022-01-18 11:30 ` Andrew Burgess via Gdb-patches
2022-01-20 17:24 ` Schimpe, Christina via Gdb-patches
2022-01-13 15:21 ` [PATCH 2/3] gdb: Add per-remote target variables for memory read and write config Christina Schimpe via Gdb-patches
2022-01-14 19:33 ` Tom Tromey
2022-01-18 11:39 ` Andrew Burgess via Gdb-patches
2022-01-24 15:06 ` Schimpe, Christina via Gdb-patches
2022-02-04 18:03 ` Andrew Burgess via Gdb-patches
2022-01-13 15:21 ` [PATCH 3/3] gdb: Remove workaround for the vCont packet Christina Schimpe via Gdb-patches
2022-01-14 19:42 ` Tom Tromey [this message]
2022-01-28 13:28 ` Schimpe, Christina via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tue6f6jn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox