Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] add caching procs to test suite
Date: Thu, 01 Aug 2013 17:58:00 -0000	[thread overview]
Message-ID: <87mwp1fg38.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51FA9663.80101@redhat.com> (Pedro Alves's message of "Thu, 01	Aug 2013 18:09:55 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> -    # Use the cached value, if it exists.  Cache value per "board" to handle
>> -    # runs with multiple options (e.g. unix/{-m32,-64}) correctly.

Pedro> Is this not a concern with the new scheme?

I thought it wasn't, but I see now that gdb_do_cache only incorporates
this into the cache file name, not the variable name.

Thanks for catching this.  I'll fix it.

Pedro> IMO, if you stripped out the GDB_PARALLEL bits, this
Pedro> should stand on its own as cleanup, and could go
Pedro> in first...

No problem.

Tom


  reply	other threads:[~2013-08-01 17:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 14:58 [PATCH 0/4] introduce test suite "parallel" mode Tom Tromey
2013-07-17 14:59 ` [PATCH 1/4] more uses of standard_output_file Tom Tromey
2013-07-17 14:59 ` [PATCH 3/4] add standard_temp_file Tom Tromey
2013-07-17 14:59 ` [PATCH 2/4] introduce parallel mode Tom Tromey
2013-07-18 12:42   ` Yao Qi
2013-07-18 13:36     ` Tom Tromey
2013-07-18 22:22       ` Yao Qi
2013-08-01 19:45         ` Tom Tromey
2013-08-01 20:58           ` Tom Tromey
2013-08-02  6:23           ` Yao Qi
2013-08-02  8:41           ` Pedro Alves
2013-08-02 15:02             ` Tom Tromey
2013-08-01 16:56   ` Pedro Alves
2013-07-17 14:59 ` [PATCH 4/4] add caching procs to test suite Tom Tromey
2013-08-01 17:10   ` Pedro Alves
2013-08-01 17:58     ` Tom Tromey [this message]
2013-08-01 17:14 ` [PATCH 0/4] introduce test suite "parallel" mode Pedro Alves
2013-08-01 19:22   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwp1fg38.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox