Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed

From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 00/14] add a smart pointer for PyObject*
Date: Fri, 11 Nov 2016 01:18:00 -0000	[thread overview]
Message-ID: <7f51de8d-912c-01d9-815f-85cc3c351f0c@redhat.com> (raw)
In-Reply-To: <1478497656-11832-1-git-send-email-tom@tromey.com>

Hi Tom,

Great to see this finally happen.  Congrats.  :-)

I read the whole series now, and it all looks great to me.  Once
patch #1 is fixed, it's fine with me to put it all in.

I did wonder about shortening the name to "gdbpy_ref".  That's how I end
up reading "gdbpy_reference" in my mind after seeing it so many
times.  :-)  You already picked a shorter name as header file
name -- py-ref.h -- and that's typed way less often.  :-)
Anyway, certainly not very important.  Just mentioning in case
you had already considered but didn't know what others would think.

I wonder whether it'd be desirable to add more methods to 
gdbpy_reference, so you'd have code like:

  gdbpy_reference sort_func = module.GetAttrString ("execute_frame_filters");

instead of:

  gdbpy_reference sort_func (PyObject_GetAttrString (module.get (),
						     "execute_frame_filters"));

etc.

And maybe add some C++ classes that inherit from gdbpy_reference for
specific Python types (e.g python tuple or list), which would provide
methods that would only make sense for those types.

Did you consider things like these?  Or maybe you did but thought
they'd obfuscate?

Also, somewhat related, I briefly looked at making our custom Python
types C++ classes before, so they could themselves hold other
C++ classes, std::string, etc., though I didn't find how to
coerce Python to use operator new with PyTypeObject types.
There must be some way though.

Thanks,
Pedro Alves

next prev parent reply	other threads:[~2016-11-11  1:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  6:00 Tom Tromey
2016-11-07  5:48 ` [RFA 05/14] Use gdbpy_reference in py-function.c Tom Tromey
2016-11-07  5:48 ` [RFA 11/14] Use gdbpy_reference in py-prettyprint.c Tom Tromey
2016-11-07  5:48 ` [RFA 08/14] Use gdbpy_reference in py-framefilter.c Tom Tromey
2016-11-07  5:48 ` [RFA 14/14] Use gdbpy_reference in gdbpy_lookup_symbol Tom Tromey
2016-11-07  5:48 ` [RFA 04/14] Use gdbpy_reference in gdbpy_string_to_argv Tom Tromey
2016-11-07  5:48 ` [RFA 01/14] Introduce py-ref.h Tom Tromey
2016-11-07  7:45   ` Jan Kratochvil
2016-11-07 15:48     ` Tom Tromey
2016-11-10 23:48   ` Pedro Alves
2016-11-12 17:31     ` Tom Tromey
2016-11-15 14:32       ` Pedro Alves
2016-11-16 23:18         ` Tom Tromey
2016-11-16 23:34           ` Pedro Alves
2016-11-07  5:48 ` [RFA 03/14] Use gdbpy_reference in py-type.c Tom Tromey
2016-11-07  5:48 ` [RFA 12/14] Use gdbpy_reference in python.c Tom Tromey
2016-11-07  5:48 ` [RFA 07/14] Use gdbpy_reference in gdbpy_breakpoints Tom Tromey
2016-11-07  5:48 ` [RFA 13/14] Use gdbpy_reference in py-value.c Tom Tromey
2016-11-07  5:48 ` [RFA 06/14] Use gdbpy_reference in gdbpy_inferiors Tom Tromey
2016-11-07  5:48 ` [RFA 10/14] Use gdbpy_reference in call_doc_function Tom Tromey
2016-11-07  5:56 ` [RFA 02/14] Change event code to use gdbpy_reference Tom Tromey
2016-11-11  0:09   ` Pedro Alves
2016-11-11  0:51     ` Pedro Alves
2016-11-07  5:57 ` [RFA 09/14] Use gdbpy_reference in py-linetable.c Tom Tromey
2016-11-08  4:07 ` [RFA 00/14] add a smart pointer for PyObject* Tom Tromey
2016-11-11  1:18 ` Pedro Alves [this message]
2016-11-11  3:34   ` Tom Tromey
2016-11-11  4:03     ` Pedro Alves
2016-11-11  5:49       ` Tom Tromey
2016-11-12 17:11   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f51de8d-912c-01d9-815f-85cc3c351f0c@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox