From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] introduce parallel mode
Date: Fri, 02 Aug 2013 08:41:00 -0000 [thread overview]
Message-ID: <51FB7097.8020900@redhat.com> (raw)
In-Reply-To: <878v0lfb62.fsf@fleche.redhat.com>
On 08/01/2013 08:44 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> Probably, we can send the output to the log, for example
> Yao> inotify_[pid].log, and check whether there is something written into
> Yao> the log in the test somewhere. If there is, emit a FAIL, which would
> Yao> be more attractive, like:
>
> I am not sure about emitting a FAIL. There won't be a corresponding
> PASS. It would be more noticeable, which is a plus; but in the absence
> of a conflict it isn't clearly a FAIL-worthy bug -- even after my series
> we'll have a few of these.
I guess a WARNING could be a better fit:
warning "string number"
Declares detection of a minor error in the test case itself. warning writes
in the log files a message beginning with `WARNING', appending the argument string.
Use warning rather than error for cases (such as communication failure to be
followed by a retry) where the test case can recover from the error.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-02 8:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:58 [PATCH 0/4] introduce test suite "parallel" mode Tom Tromey
2013-07-17 14:59 ` [PATCH 1/4] more uses of standard_output_file Tom Tromey
2013-07-17 14:59 ` [PATCH 3/4] add standard_temp_file Tom Tromey
2013-07-17 14:59 ` [PATCH 2/4] introduce parallel mode Tom Tromey
2013-07-18 12:42 ` Yao Qi
2013-07-18 13:36 ` Tom Tromey
2013-07-18 22:22 ` Yao Qi
2013-08-01 19:45 ` Tom Tromey
2013-08-01 20:58 ` Tom Tromey
2013-08-02 6:23 ` Yao Qi
2013-08-02 8:41 ` Pedro Alves [this message]
2013-08-02 15:02 ` Tom Tromey
2013-08-01 16:56 ` Pedro Alves
2013-07-17 14:59 ` [PATCH 4/4] add caching procs to test suite Tom Tromey
2013-08-01 17:10 ` Pedro Alves
2013-08-01 17:58 ` Tom Tromey
2013-08-01 17:14 ` [PATCH 0/4] introduce test suite "parallel" mode Pedro Alves
2013-08-01 19:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB7097.8020900@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox