From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] introduce parallel mode
Date: Fri, 02 Aug 2013 06:23:00 -0000 [thread overview]
Message-ID: <51FB5024.9040001@codesourcery.com> (raw)
In-Reply-To: <878v0lfb62.fsf@fleche.redhat.com>
On 08/02/2013 03:44 AM, Tom Tromey wrote:
> I am not sure about emitting a FAIL. There won't be a corresponding
> PASS. It would be more noticeable, which is a plus; but in the absence
> of a conflict it isn't clearly a FAIL-worthy bug -- even after my series
> we'll have a few of these.
Emitting a FAIL explicitly gives writer an alert, otherwise, reviewers
have to screen the test case manually, like what we do nowadays for
duplicated test results. The test submission criteria is "zero-fail" in
gdb.sum, and I afraid few people pays much attention on something
suspicious in gdb.log.
>
> So for now I am just teeing the output to the log file:
>
> set inotify_pid [exec inotifywait -r -m -e move,create,delete . \
> --exclude $exclusion_re \
> |& tee -a $outdir/$tool.log &]
>
> This way it will show up in on the terminal but also in the log.
That is good to me too.
>
> I'm open to discussion about your idea though. I'm really not sure.
I don't have a strong opinion on either of them. I am OK to move on as
what we are doing in these patches. We can switch to emitting-fail
later if we think it is really necessary.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-08-02 6:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:58 [PATCH 0/4] introduce test suite "parallel" mode Tom Tromey
2013-07-17 14:59 ` [PATCH 3/4] add standard_temp_file Tom Tromey
2013-07-17 14:59 ` [PATCH 2/4] introduce parallel mode Tom Tromey
2013-07-18 12:42 ` Yao Qi
2013-07-18 13:36 ` Tom Tromey
2013-07-18 22:22 ` Yao Qi
2013-08-01 19:45 ` Tom Tromey
2013-08-01 20:58 ` Tom Tromey
2013-08-02 6:23 ` Yao Qi [this message]
2013-08-02 8:41 ` Pedro Alves
2013-08-02 15:02 ` Tom Tromey
2013-08-01 16:56 ` Pedro Alves
2013-07-17 14:59 ` [PATCH 1/4] more uses of standard_output_file Tom Tromey
2013-07-17 14:59 ` [PATCH 4/4] add caching procs to test suite Tom Tromey
2013-08-01 17:10 ` Pedro Alves
2013-08-01 17:58 ` Tom Tromey
2013-08-01 17:14 ` [PATCH 0/4] introduce test suite "parallel" mode Pedro Alves
2013-08-01 19:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB5024.9040001@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox