From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes.
Date: Wed, 13 Mar 2013 21:10:00 -0000 [thread overview]
Message-ID: <5140EB48.1020307@redhat.com> (raw)
In-Reply-To: <87k3pb9fy5.fsf@fleche.redhat.com>
On 13/03/13 20:56, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> Currently (before my patch) the commands self parse their own --
> Phil> values. One of the things from the last review was you wanted where
> Phil> possible to use mi-getopt to parse options.
>
> Phil> It would seem weird to me to mix - and -- in these commands.
>
> I mean if you change the string in the mi_opt table from
> "no-frame-filters" to "-no-frame-filters", then this should cause
> mi_getopt to accept the "--" form without affecting other callers.
>
> Tom
>
Originally I did do that, but the error message if you mistype an
option generated by mi_getopt is wrong:
-stack-list-frames --no-frame-falters
^error,msg="-stack-list-frames: Unknown option ``-no-frame-falters''"
(gdb)
The error messages always assumes a "-". And if I was going to end up
patching mi_getopt then I might as well go ahead and handle "--"
options properly.
I am not sure what you mean other callers, though. Other callers are
not affected. "-" options work fine still, as do "--". Anyway, I have
no strong feelings on this. If the error message above is fine with
you we can do that, or keep the existing patch.
What do you prefer?
Cheers,
Phil
next prev parent reply other threads:[~2013-03-13 21:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 22:13 Phil Muldoon
2013-03-12 20:43 ` Tom Tromey
2013-03-12 20:52 ` Phil Muldoon
2013-03-13 12:15 ` Phil Muldoon
2013-03-13 17:48 ` Tom Tromey
2013-03-13 19:41 ` Phil Muldoon
2013-03-13 20:27 ` Tom Tromey
2013-03-13 20:53 ` Phil Muldoon
2013-03-13 20:56 ` Tom Tromey
2013-03-13 21:10 ` Phil Muldoon [this message]
2013-03-14 17:54 ` Tom Tromey
2013-03-14 19:35 ` Phil Muldoon
-- strict thread matches above, loose matches on Subject: below --
2013-05-06 8:23 Phil Muldoon
2013-05-06 20:42 ` Tom Tromey
2013-05-07 8:23 ` Phil Muldoon
2013-05-07 14:02 ` Tom Tromey
2013-05-08 10:18 ` Phil Muldoon
2013-05-08 19:47 ` Tom Tromey
2013-05-10 10:45 ` Phil Muldoon
2013-04-22 16:01 Phil Muldoon
2013-04-26 11:19 ` Tom Tromey
2012-11-30 14:31 Phil Muldoon
2012-12-05 17:11 ` Tom Tromey
2012-12-07 13:56 ` Phil Muldoon
2012-12-10 21:03 ` Tom Tromey
2013-02-05 12:08 ` Phil Muldoon
2013-02-07 21:32 ` Tom Tromey
2013-02-20 15:17 ` Phil Muldoon
2013-02-20 20:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140EB48.1020307@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox