From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes.
Date: Wed, 13 Mar 2013 12:15:00 -0000 [thread overview]
Message-ID: <51406DCD.7050007@redhat.com> (raw)
In-Reply-To: <513F9576.30201@redhat.com>
On 12/03/13 20:52, Phil Muldoon wrote:
> On 12/03/13 20:43, Tom Tromey wrote:
>
>> Phil> + /* Run the inbuilt backtrace if there are no filters registered, or
>> Phil> + if there was an error in the Python backtracing output, or if
>> Phil> + frame-filters are disabled. */
>> Phil> + if (! frame_filters || raw_arg || result == PY_BT_ERROR
>> Phil> + || result == PY_BT_NO_FILTERS)
>>
>> It seems to me that the PY_BT_ERROR case should not be here, since the
>> MI client could get a partially filtered trace followed by the normal
>> trace.
>
> Yeah you are right. It's a pain to figure out what to do here. I suspect in
> MI case just abandon the trace.
I looked at this in a little more detail this morning.
apply_frame_filter in py-framefilter.c, will still try to print the
whole backtrace if it errors on one frame. It will print the error
message and move onto the next frame. So PY_BT_ERROR is wrong in all
cases, both in MI and CLI. I'll fix this up. Good spot. So bear
this in mind when you (or anyone) reviews the CLI case. It is fixed
locally.
Cheers
Phil
next prev parent reply other threads:[~2013-03-13 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 22:13 Phil Muldoon
2013-03-12 20:43 ` Tom Tromey
2013-03-12 20:52 ` Phil Muldoon
2013-03-13 12:15 ` Phil Muldoon [this message]
2013-03-13 17:48 ` Tom Tromey
2013-03-13 19:41 ` Phil Muldoon
2013-03-13 20:27 ` Tom Tromey
2013-03-13 20:53 ` Phil Muldoon
2013-03-13 20:56 ` Tom Tromey
2013-03-13 21:10 ` Phil Muldoon
2013-03-14 17:54 ` Tom Tromey
2013-03-14 19:35 ` Phil Muldoon
-- strict thread matches above, loose matches on Subject: below --
2013-05-06 8:23 Phil Muldoon
2013-05-06 20:42 ` Tom Tromey
2013-05-07 8:23 ` Phil Muldoon
2013-05-07 14:02 ` Tom Tromey
2013-05-08 10:18 ` Phil Muldoon
2013-05-08 19:47 ` Tom Tromey
2013-05-10 10:45 ` Phil Muldoon
2013-04-22 16:01 Phil Muldoon
2013-04-26 11:19 ` Tom Tromey
2012-11-30 14:31 Phil Muldoon
2012-12-05 17:11 ` Tom Tromey
2012-12-07 13:56 ` Phil Muldoon
2012-12-10 21:03 ` Tom Tromey
2013-02-05 12:08 ` Phil Muldoon
2013-02-07 21:32 ` Tom Tromey
2013-02-20 15:17 ` Phil Muldoon
2013-02-20 20:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51406DCD.7050007@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox