From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Cc: sami wagiaalla <swagiaal@redhat.com>
Subject: Re: [patch] Remove redundant symbol naming from new_symbol
Date: Tue, 01 Jun 2010 19:21:00 -0000 [thread overview]
Message-ID: <4C055DBD.7040300@redhat.com> (raw)
In-Reply-To: <4BFE83F0.2090908@redhat.com>
On 05/27/2010 07:38 AM, sami wagiaalla wrote:
> This patch removes the redundant calls.
FWIW, I think this patch should be approved; the additional calls to
dwarf2_full_name do appear to be redundant, since SYMBOL_SET_NAMES is
called unconditionally for every symbol with DW_AT_name.
[The only question is whether dwarf2_full_name and dwarf2_physname could
return different "names" for these DIEs, and since the DIEs do not
represent a class method, the "names" will be identical.]
Keith
next prev parent reply other threads:[~2010-06-01 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 15:00 sami wagiaalla
2010-06-01 19:21 ` Keith Seitz [this message]
2010-06-01 20:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C055DBD.7040300@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox