From: Daniel Jacobowitz <drow@mvista.com>
To: gdb <gdb@sources.redhat.com>
Subject: Re: C++/Java regressions
Date: Wed, 26 Nov 2003 15:32:00 -0000 [thread overview]
Message-ID: <20031126153234.GA10644@nevyn.them.org> (raw)
In-Reply-To: <m3vfp7vkpy.fsf@gossamer.airs.com>
On Tue, Nov 25, 2003 at 11:04:41PM -0500, Ian Lance Taylor wrote:
> Then when gdb goes to look up T5<int>, it finds the DWARF psymbol for
> the class itself, but it also finds that the symbol might be a
> namespace. It then decides that it is a namespace.
That sounds like the bit that's wrong. If it found a psymbol for the
class why does it decide to call it a namespace?
> The problem with t5i, besides some demangler changes which have
> already been addressed, is that gdb doesn't recognize that a
> constructor function is, in fact, a constructor. That's because the
> code in c-typeprint.c does this:
>
> char *method_name = TYPE_FN_FIELDLIST_NAME (type, i);
> char *name = type_name_no_tag (type);
> int is_constructor = name && strcmp (method_name, name) == 0;
>
> and this:
>
> char *physname = TYPE_FN_FIELD_PHYSNAME (f, j);
> int is_full_physname_constructor =
> is_constructor_name (physname)
> || is_destructor_name (physname)
> || method_name[0] == '~';
>
> The first fails because name is "T5<int>" and method_name is "T5".
> The second fails because this is dealing with debugging information,
> and gcc does not emit any physical symbol name information for class
> constructors.
>
> This could be addressed by changing the simple test for is_constructor
> to a more complex test which ignore the template arguments when
> determining whether method_name was the same as name.
Yes, I have a patch sitting here (for some time) which does this. It
got mixed in with some other patches that aren't ready for prime-time
yet.
I'm considering a routine for canonicalization of C++ demangled names.
That's the only way we're going to get templates.exp to start working
robustly. For cv-qualifiers it's fairly easy, and most of what gets
mangled is to accomodate either space efficiency or linker character
sets so that's not all so important. "Unsigned" <-> "unsigned int" is
also easy. Template arguments can be a little harder so we may punt.
Perhaps next month.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-11-26 15:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-25 1:37 David Carlton
2003-11-25 1:48 ` The demangler was rewritten from scratch! Andrew Cagney
2003-11-25 3:58 ` C++/Java regressions Ian Lance Taylor
2003-11-26 4:04 ` Ian Lance Taylor
2003-11-26 15:32 ` Daniel Jacobowitz [this message]
2003-11-26 21:05 ` Ian Lance Taylor
2003-11-26 21:11 ` David Carlton
2003-11-26 21:12 ` Daniel Jacobowitz
2003-11-26 21:32 ` Ian Lance Taylor
2003-12-01 16:45 ` Daniel Jacobowitz
2003-11-30 2:57 ` Jim Blandy
2003-11-30 3:12 ` Daniel Jacobowitz
2003-11-25 4:44 Michael Elizabeth Chastain
2003-11-25 17:54 ` Ian Lance Taylor
2003-11-25 14:49 Michael Elizabeth Chastain
2003-11-25 15:06 ` Daniel Jacobowitz
2003-11-25 15:33 Michael Elizabeth Chastain
2003-11-25 17:06 Michael Elizabeth Chastain
2003-11-25 17:14 ` David Carlton
2003-11-25 17:59 ` Daniel Jacobowitz
2003-11-26 21:18 Michael Elizabeth Chastain
2003-11-26 21:33 ` Ian Lance Taylor
2003-11-26 21:44 Michael Elizabeth Chastain
2003-11-26 22:21 ` Ian Lance Taylor
2003-11-26 22:28 ` Daniel Jacobowitz
2003-11-26 22:34 ` Ian Lance Taylor
2003-11-26 22:48 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031126153234.GA10644@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox