From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/19] Convert std::unordered_{set,map} to gdb implementations
Date: Mon, 17 Mar 2025 23:27:58 -0400 [thread overview]
Message-ID: <0cbb4330-b9b1-44d2-b0bc-53e1f25044f5@simark.ca> (raw)
In-Reply-To: <20250317-replace-std-stuff-v1-0-7ba4ee88e218@tromey.com>
On 2025-03-17 22:14, Tom Tromey wrote:
> This changes a number of uses of std::unordered_{set,map} to the gdb::
> equivalents.
>
> Not every spot is converted. I only changed the ones that I felt I
> could reasonably test; or in one or two cases, I left one alone since
> it will be addressed some other way.
>
> I've also got some similar patches to reduce the use of htab_t. I'll
> send that as a separate series sometime later.
>
> Regression tested on x86-64 Fedora 40.
>
> Signed-off-by: Tom Tromey <tom@tromey.com>
Modulo the minor questions/comments I sent, this LGTM. Most of it is
1:1 replacement, so it's relatively trivial.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Thanks,
Simon
next prev parent reply other threads:[~2025-03-18 3:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 2:14 Tom Tromey
2025-03-18 2:14 ` [PATCH 01/19] Use gdb unordered set and map in corelow.c Tom Tromey
2025-03-18 2:14 ` [PATCH 02/19] Use gdb unordered set in breakpoint.c Tom Tromey
2025-03-18 2:14 ` [PATCH 03/19] Use gdb unordered map in dictionary.c Tom Tromey
2025-03-18 2:14 ` [PATCH 04/19] Use gdb unordered map in gdb_bfd.c Tom Tromey
2025-03-18 2:14 ` [PATCH 05/19] Use gdb unordered set in symtab.c Tom Tromey
2025-03-18 2:14 ` [PATCH 06/19] Use gdb unordered map in ada-exp.y Tom Tromey
2025-03-18 2:15 ` [PATCH 07/19] Use gdb unordered map in inferior.h Tom Tromey
2025-03-18 2:15 ` [PATCH 08/19] Use gdb unordered map in stap-probe.c Tom Tromey
2025-03-18 2:15 ` [PATCH 09/19] Use gdb unordered map for complaints Tom Tromey
2025-03-18 2:15 ` [PATCH 10/19] Use gdb unordered map in linux-nat.c Tom Tromey
2025-03-18 2:15 ` [PATCH 11/19] Use gdb unordered set in linux-procfs.c Tom Tromey
2025-03-18 2:15 ` [PATCH 12/19] Use gdb unordered set and map in Python layer Tom Tromey
2025-03-18 2:15 ` [PATCH 13/19] Use gdb unordered map in ravenscar.c Tom Tromey
2025-03-18 2:15 ` [PATCH 14/19] Use gdb unordered map in target.c Tom Tromey
2025-03-18 2:15 ` [PATCH 15/19] Use gdb unordered set and map in unit tests Tom Tromey
2025-03-18 2:15 ` [PATCH 16/19] Use gdb unordered map in xml-tdesc.c Tom Tromey
2025-03-18 2:15 ` [PATCH 17/19] Use gdb unordered set and map in cp-namespace.c Tom Tromey
2025-03-18 3:20 ` Simon Marchi
2025-03-18 11:32 ` Tom Tromey
2025-03-18 2:15 ` [PATCH 18/19] Use gdb unordered map in tui-io.c Tom Tromey
2025-03-18 3:26 ` Simon Marchi
2025-03-18 11:34 ` Tom Tromey
2025-03-18 2:15 ` [PATCH 19/19] Use gdb unordered map in regcache.c Tom Tromey
2025-03-18 3:27 ` Simon Marchi [this message]
2025-03-18 11:43 ` [PATCH 00/19] Convert std::unordered_{set,map} to gdb implementations Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cbb4330-b9b1-44d2-b0bc-53e1f25044f5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox